Allow "cross-compiling" with GRIT

chrome/tools/build/repack_locales.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Helper script to repack paks for a list of locales.
 
 Gyp doesn't have any built-in looping capability, so this just provides a way to
 loop over a list of locales when repacking pak files, thus avoiding a
 proliferation of mostly duplicate, cut-n-paste gyp actions.
 """
 
 import getopt
 import os
 import sys
 
 sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', '..',
                              'tools', 'grit'))
 from grit.format import data_pack
 
 # The gyp "branding" variable.
 BRANDING = None
 
 # Some build paths defined by gyp.
 GRIT_DIR = None
 SHARE_INT_DIR = None
 INT_DIR = None
 
+# The target platform. If it is not defined, sys.platform will be used.
+PLATFORM = None

[tony, 2012/07/31 16:47:00]

I would call this OS since we call it OS in the gyp files.

[newt (away), 2012/07/31 21:13:54]

Done.

 
 class Usage(Exception):
   def __init__(self, msg):
     self.msg = msg
 
 
 def calc_output(locale):
   """Determine the file that will be generated for the given locale."""
   #e.g. '<(INTERMEDIATE_DIR)/repack/da.pak',
   # For Fake Bidi, generate it at a fixed path so that tests can safely
   # reference it.
   if locale == 'fake-bidi':
     return '%s/%s.pak' % (INT_DIR, locale)
-  if sys.platform in ('darwin',):
+  if PLATFORM == 'mac' or (PLATFORM == None and sys.platform in ('darwin',)):
     # For Cocoa to find the locale at runtime, it needs to use '_' instead
     # of '-' (http://crbug.com/20441).  Also, 'en-US' should be represented
     # simply as 'en' (http://crbug.com/19165, http://crbug.com/25578).
     if locale == 'en-US':
       locale = 'en'
     return '%s/repack/%s.lproj/locale.pak' % (INT_DIR, locale.replace('-', '_'))
   else:
     return os.path.join(INT_DIR, 'repack', locale + '.pak')
 
 
@@ skipping 71 matching lines @@
     inputs += calc_inputs(locale)
     output = calc_output(locale)
     data_pack.DataPack.RePack(output, inputs)
 
 
 def DoMain(argv):
   global BRANDING
   global GRIT_DIR
   global SHARE_INT_DIR
   global INT_DIR
+  global PLATFORM
 
-  short_options = 'iog:s:x:b:h'
+  short_options = 'iog:s:x:b:hp:'
   long_options = 'help'
 
   print_inputs = False
   print_outputs = False
   usage_msg = ''
 
   helpstr = """\
-Usage:  %s [-h] [-i | -o] -g <DIR> -x <DIR> -s <DIR> -b <branding> <locale> [...]
+Usage:  %s [-h] [-i | -o] -g <DIR> -x <DIR> -s <DIR> -b <branding> [-p <platform>] <locale> [...]
   -h, --help     Print this help, then exit.
   -i             Print the expected input file list, then exit.
   -o             Print the expected output file list, then exit.
   -g DIR         GRIT build files output directory.
   -x DIR         Intermediate build files output directory.
   -s DIR         Shared intermediate build files output directory.
   -b branding    Branding type of this build.
+  -p platform    The target platform. (e.g. mac, linux, win and etc.)

[tony, 2012/07/31 16:47:00]

Nit: os

[newt (away), 2012/07/31 21:13:54]

Done.

   locale [...]   One or more locales to repack.""" % (
       os.path.basename(__file__))
 
   try:
     opts, locales = getopt.getopt(argv, short_options, long_options)
   except getopt.GetoptError, msg:
     raise Usage(str(msg))
 
   if not locales:
     usage_msg = 'Please specificy at least one locale to process.\n'
 
   for o, a in opts:
     if o in ('-i'):
       print_inputs = True
     elif o in ('-o'):
       print_outputs = True
     elif o in ('-g'):
       GRIT_DIR = a
     elif o in ('-s'):
       SHARE_INT_DIR = a
     elif o in ('-x'):
       INT_DIR = a
     elif o in ('-b'):
       BRANDING = a
+    elif o in ('-p'):

[tony, 2012/07/31 16:47:00]

Hmm, the use of 'in' here happens to work, but it's weird since it's doing a
substring search.  Not your fault, just pointing it out.

[newt (away), 2012/07/31 21:13:54]

I figured I might as well fix these.

+      PLATFORM = a
     elif o in ('-h', '--help'):
       raise Usage(helpstr)
 

[tony, 2012/07/31 16:47:00]

I would probably normalize OS around here.  E.g.,
if not OS:
  if sys.platform == 'darwin':
    OS = 'mac'
  elif sys.platform.startswith('linux'):
    OS = 'linux'
  elif sys.platform in ('cygwin', 'win32'):
    OS = 'win'
  else:
    OS = sys.platform

Then you could simplify the condition in calc_output.

[newt (away), 2012/07/31 21:13:54]

Done.  This is much cleaner.

   if not (GRIT_DIR and INT_DIR and SHARE_INT_DIR):
     usage_msg += 'Please specify all of "-g" and "-x" and "-s".\n'
   if print_inputs and print_outputs:
     usage_msg += 'Please specify only one of "-i" or "-o".\n'
   # Need to know the branding, unless we're just listing the outputs.
   if not print_outputs and not BRANDING:
     usage_msg += 'Please specify "-b" to determine the input files.\n'
 
   if usage_msg:
     raise Usage(usage_msg)
 
   if print_inputs:
     return list_inputs(locales)
 
   if print_outputs:
     return list_outputs(locales)
 
   return repack_locales(locales)
 
 if __name__ == '__main__':
   results = DoMain(sys.argv[1:])
   if results:
     print results