Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 10830028: IndexedDB: Send cursor data along with success messages (Closed)

Created:
8 years, 5 months ago by jsbell
Modified:
8 years, 4 months ago
Reviewers:
michaeln, dgrogan
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, alecflett
Visibility:
Public.

Description

IndexedDB: Send cursor data along with success messages Chromium already behaves like this in the IPC plumbing for IDB, but the code can be simplified by pushing this into the WebKit implementation itself. Full landing sequence is: (1) WebKit prep: Add new API stubs http://webkit.org/b/92414 (2) Chromium changes: dispatch to old and new API https://chromiumcodereview.appspot.com/10830028 (this patch) (3) WebKit changes: use the new API http://webkit.org/b/92278 (4) Chromium cleanup: delete old API usage (5) WebKit changes: delete old API Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150883

Patch Set 1 #

Patch Set 2 : Work with old and new WK #

Patch Set 3 : Comment tweaks and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
M content/browser/in_process_webkit/indexed_db_callbacks.h View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_callbacks.cc View 1 2 3 chunks +39 lines, -0 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M content/common/indexed_db/proxy_webidbcursor_impl.h View 1 2 3 chunks +4 lines, -0 lines 0 comments Download
M content/common/indexed_db/proxy_webidbcursor_impl.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
dgrogan@ - ptal
8 years, 4 months ago (2012-07-30 23:28:17 UTC) #1
dgrogan
LGTM Does this sequence of changes cause any behavior change? If not, do you want ...
8 years, 4 months ago (2012-07-31 17:19:18 UTC) #2
jsbell
On 2012/07/31 17:19:18, dgrogan wrote: > Does this sequence of changes cause any behavior change? ...
8 years, 4 months ago (2012-08-01 01:00:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/10830028/2002
8 years, 4 months ago (2012-08-09 18:36:50 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 20:30:50 UTC) #5
Change committed as 150883

Powered by Google App Engine
This is Rietveld 408576698