Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 10830004: Fix wrong usage of MethodCall resposne. (Closed)

Created:
8 years, 5 months ago by Seigo Nonaka
Modified:
8 years, 5 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix wrong usage of MethodCall resposne. BUG=None TEST=ran chromeos_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148537

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Same for IBusEngineService #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -40 lines) Patch
M chromeos/dbus/ibus/ibus_engine_factory_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_service.cc View 1 2 11 chunks +25 lines, -37 lines 0 comments Download
M chromeos/dbus/ibus/ibus_engine_service_unittest.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Seigo Nonaka
8 years, 5 months ago (2012-07-25 14:41:38 UTC) #1
satorux1
LGTM. Sorry that I didn't catch them!
8 years, 5 months ago (2012-07-25 18:51:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/10830004/5001
8 years, 5 months ago (2012-07-26 11:41:27 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 12:40:52 UTC) #4
Change committed as 148537

Powered by Google App Engine
This is Rietveld 408576698