Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: chromeos/dbus/ibus/ibus_engine_factory_service.cc

Issue 10830004: Fix wrong usage of MethodCall resposne. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Same for IBusEngineService Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/ibus/ibus_engine_factory_service.cc
diff --git a/chromeos/dbus/ibus/ibus_engine_factory_service.cc b/chromeos/dbus/ibus/ibus_engine_factory_service.cc
index 9178b4d5ad42869a44830a964204c5d64da0ccf7..6241ad0a2df7a971e35783051d2073edcae06803 100644
--- a/chromeos/dbus/ibus/ibus_engine_factory_service.cc
+++ b/chromeos/dbus/ibus/ibus_engine_factory_service.cc
@@ -65,11 +65,11 @@ class IBusEngineFactoryServiceImpl : public IBusEngineFactoryService {
if(create_engine_handler_.is_null()) {
LOG(WARNING) << "The CreateEngine handler is NULL.";
} else {
+ dbus::Response* response = dbus::Response::FromMethodCall(method_call);
+ dbus::MessageWriter writer(response);
const dbus::ObjectPath path = create_engine_handler_.Run(engine_name);
- scoped_ptr<dbus::Response> response(dbus::Response::CreateEmpty());
- dbus::MessageWriter writer(response.get());
writer.AppendObjectPath(path);
- response_sender.Run(response.get());
+ response_sender.Run(response);
}
}
« no previous file with comments | « no previous file | chromeos/dbus/ibus/ibus_engine_factory_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698