Print preview: Handle all tab navigations in PrintPreviewTabController instead of in two places. Ha…

Print preview: Handle all tab navigations in PrintPreviewTabController instead of in two places. Handle webpage self-reloads properly.

BUG=142260
TEST=Manual, see bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152661

[Lei Zhang, 2012-08-21 18:21:23]

https://chromiumcodereview.appspot.com/10829463/diff/7/chrome/browser/printin...
File chrome/browser/printing/print_preview_message_handler.cc (left):

https://chromiumcodereview.appspot.com/10829463/diff/7/chrome/browser/printin...
chrome/browser/printing/print_preview_message_handler.cc:257: // Cloud print
sign-in reloads the page.
I don't think we do this anymore. Cloud print sign-in is in a separate
constrained window on Linux dev channel here. I assume the same on CrOS? This
must have been to support the old cloud print sign-in workflow before the
redesign.

[Albert Bodenhamer, 2012-08-21 18:28:55]

LGTM

Please double check that sign in still works.

https://chromiumcodereview.appspot.com/10829463/diff/7/chrome/browser/printin...
File chrome/browser/printing/print_preview_message_handler.cc (left):

https://chromiumcodereview.appspot.com/10829463/diff/7/chrome/browser/printin...
chrome/browser/printing/print_preview_message_handler.cc:257: // Cloud print
sign-in reloads the page.
The need for this actually went away quite a while before the recent redesign. 
Thanks for catching it.

On 2012/08/21 18:21:23, Lei Zhang wrote:
> I don't think we do this anymore. Cloud print sign-in is in a separate
> constrained window on Linux dev channel here. I assume the same on CrOS? This
> must have been to support the old cloud print sign-in workflow before the
> redesign.

[Lei Zhang, 2012-08-21 18:36:59]

Cloud sign in still works for me.

[commit-bot: I haz the power, 2012-08-21 18:38:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/10829463/7

[commit-bot: I haz the power, 2012-08-21 20:11:27]

Try job failure for 10829463-7 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-08-21 20:14:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/10829463/7

[commit-bot: I haz the power, 2012-08-21 23:02:38]

Change committed as 152661