Print preview: Handle all tab navigations in PrintPreviewTabController instead of in two places. Ha…

chrome/browser/printing/print_preview_message_handler.cc

Index: chrome/browser/printing/print_preview_message_handler.cc
===================================================================
--- chrome/browser/printing/print_preview_message_handler.cc	(revision 152498)
+++ chrome/browser/printing/print_preview_message_handler.cc	(working copy)
@@ -26,7 +26,6 @@
 #include "printing/print_job_constants.h"
 
 using content::BrowserThread;
-using content::NavigationController;
 using content::WebContents;
 
 namespace {
@@ -248,22 +247,4 @@
   return handled;
 }
 
-void PrintPreviewMessageHandler::NavigateToPendingEntry(
-    const GURL& url,
-    NavigationController::ReloadType reload_type) {
-  TabContents* tab = tab_contents();
-  TabContents* preview_tab = GetPrintPreviewTab();
-  if (tab == preview_tab) {
-    // Cloud print sign-in reloads the page.

[Lei Zhang, 2012/08/21 18:21:23]

I don't think we do this anymore. Cloud print sign-in is in a separate
constrained window on Linux dev channel here. I assume the same on CrOS? This
must have been to support the old cloud print sign-in workflow before the
redesign.

[Albert Bodenhamer, 2012/08/21 18:28:55]

The need for this actually went away quite a while before the recent redesign. 
Thanks for catching it.

On 2012/08/21 18:21:23, Lei Zhang wrote:

-    DCHECK(PrintPreviewTabController::IsPrintPreviewURL(url));
-    DCHECK_EQ(NavigationController::RELOAD, reload_type);
-    return;
-  }
-  // If |tab| is navigating and it has a print preview tab, notify |tab| to
-  // consider print preview done so it unfreezes the renderer in the case of
-  // window.print().
-  if (preview_tab)
-    tab->print_view_manager()->PrintPreviewDone();
-}
-
 }  // namespace printing