Chromium Code Reviews
Help | Chromium Project | Sign in
(708)

Issue 10829456: Check that index and length are Smi in bounds check. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by Toon Verwaest
Modified:
2 years, 11 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Check that index and length are Smi in bounds check. BUG=chromium:142218 R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12362

Patch Set 1 #

Patch Set 2 : Porting changes to ARM and ia32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -16 lines) Patch
M src/arm/lithium-codegen-arm.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-142218.js View 1 chunk +11 lines, -16 lines 0 comments Download
Trybot results:
Commit: (user is not authenticated) CQ not working?

Messages

Total messages: 2 (0 generated)
Toon Verwaest
PTAL.
2 years, 11 months ago (2012-08-21 16:30:05 UTC) #1
danno
2 years, 11 months ago (2012-08-21 16:44:24 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f