Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed

Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed
https://bugs.webkit.org/show_bug.cgi?id=94232

Reviewed by James Robinson.

Source/WebCore:

CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be
called when there is no renderer present or it will crash.

Chromium bug: crbug.com/125482

Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):

Source/WebKit/chromium:

Also updated the finishAllRenderingAfterContextLost to properly fail
renderer initialization.

* tests/CCLayerTreeHostImplTest.cpp:


TBR=danakj@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125941

[mal, 2012-08-18 22:45:09]

https://chromiumcodereview.appspot.com/10829399/diff/1/Source/WebKit/chromium...
File Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (right):

https://chromiumcodereview.appspot.com/10829399/diff/1/Source/WebKit/chromium...
Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:287:
m_hostImpl->initializeLayerRenderer(FakeWebCompositorOutputSurface::create(adoptPtr(new
FakeWebGraphicsContext3DMakeCurrentFails)), UnthrottledUploader);
third_party/WebKit/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp: In
member function ‘virtual
void<unnamed>::CCLayerTreeHostImplTest_scrollWithoutRenderer_Test::TestBody()’:
third_party/WebKit/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:287:
error: ‘FakeWebCompositorOutputSurface’ has not been declared

Looks like FakewebCompositorOutputSurface was added after the 1229 branch, so
this fails.

I'll look around to see if someone can revert this... if that hasn't happened
before you read
this, please revert (or fix :)). Thanks

[mal, 2012-08-18 22:57:51]

I was able to recall my dusty olde webkit credentials and reverted this on the
branch:

http://trac.webkit.org/changeset/125970

[danakj, 2012-08-20 15:01:24]

On 2012/08/18 22:57:51, mal wrote:
> I was able to recall my dusty olde webkit credentials and reverted this on the
> branch:
> 
> http://trac.webkit.org/changeset/125970

Ah, okay! Sorry for that, I'll re-merge without the test changes.