Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 10829369: Add media dep to NaCl in preparation of shared target. (Closed)

Created:
8 years, 4 months ago by DaleCurtis
Modified:
8 years, 4 months ago
Reviewers:
nfullagar, bradn, nfullagar1
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add media dep to NaCl in preparation of shared target. media will soon be exposing a target which NaCl can use for interfacing with the shared memory between the renderer and browser side processes. Using the new target allows a bunch of duplicated code to be removed ensuring NaCl never has to worry about being out of date. BUG=123203 TEST=none Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9566

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
DaleCurtis
PTAL. This is the product of our discussion via chat.
8 years, 4 months ago (2012-08-17 02:11:20 UTC) #1
nfullagar
lgtm, commit after http://codereview.chromium.org/10826296/ goes in on the chrome side. (One of the integration bots ...
8 years, 4 months ago (2012-08-17 20:20:28 UTC) #2
bradn
8 years, 4 months ago (2012-08-24 20:21:09 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698