Disable warnings in harfbuzz/ for Android when not using clang.

Disable warnings in harfbuzz/ for Android when not using clang.

The Android NDK compilers, both on GCC 4.2 and on GCC 4.6, throw a warning about
incompatible pointer signedness in one of harfbuzz' APIs. That's where the fun
comes in: no flag is currently able to disable the warning when using Android's GCCs.
We therefore have to disable all warnings.

This is unfortunate, but we should still be getting sufficient coverage
for other warnings from Linux and Android-clang builds.

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151944

[Peter Beverloo, 2012-08-16 13:35:44]

Nico: Mind reviewing this?
David: This issue seems to be specific to Android's GCC version. Should I file
this somewhere internally?

[Nico, 2012-08-16 14:52:49]

Since we build this code on the linux bots, and since you guys seem to have a
clang bot for the android build too, do you think it'd be acceptable to just
build the whole target with -w on android? That'd be a bit simpler.

[Peter Beverloo, 2012-08-16 15:04:16]

On 2012/08/16 14:52:49, Nico wrote:
> Since we build this code on the linux bots, and since you guys seem to have a
> clang bot for the android build too, do you think it'd be acceptable to just
> build the whole target with -w on android? That'd be a bit simpler.

I preferred to do this with as little code as possible. The complexity may
indeed not be worth the gain. Done.

[Nico, 2012-08-16 15:06:10]

LGTM

https://chromiumcodereview.appspot.com/10829354/diff/3003/third_party/harfbuz...
File third_party/harfbuzz/harfbuzz.gyp (right):

https://chromiumcodereview.appspot.com/10829354/diff/3003/third_party/harfbuz...
third_party/harfbuzz/harfbuzz.gyp:72: '-w',
nit: unless gcc emits this warning only for c files, you might want to use
'cflags', in case some harfbuzz files change from .c to .cpp in the future.

[Peter Beverloo, 2012-08-16 15:38:26]

On 2012/08/16 15:06:10, Nico wrote:
> LGTM
> 
>
https://chromiumcodereview.appspot.com/10829354/diff/3003/third_party/harfbuz...
> File third_party/harfbuzz/harfbuzz.gyp (right):
> 
>
https://chromiumcodereview.appspot.com/10829354/diff/3003/third_party/harfbuz...
> third_party/harfbuzz/harfbuzz.gyp:72: '-w',
> nit: unless gcc emits this warning only for c files, you might want to use
> 'cflags', in case some harfbuzz files change from .c to .cpp in the future.

Done, thank you. This is why you need to come to London again! ;-)

[commit-bot: I haz the power, 2012-08-16 15:38:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@chromium.org/10829354/10002

[commit-bot: I haz the power, 2012-08-16 17:05:47]

Try job failure for 10829354-10002 (retry) on linux_rel for step
"content_browsertests".
It's a second try, previously, steps "interactive_ui_tests,
content_browsertests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-16 17:08:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@chromium.org/10829354/10002

[commit-bot: I haz the power, 2012-08-16 19:27:44]

Change committed as 151944

[digit1, 2012-08-16 19:28:08]

lgtm.

Note that I'm not really aware of this GCC limitation, but the patch doesn't
seem to be too harmful. On the other hand, we should try fixing the harfbuzz
headers and send a patch upstream.