Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: third_party/harfbuzz/harfbuzz.gyp

Issue 10829354: Disable warnings in harfbuzz/ for Android when not using clang. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 # Set to 1 to use Harfbuzz-NG instead of Harfbuzz. 7 # Set to 1 to use Harfbuzz-NG instead of Harfbuzz.
8 # Under development: http://crbug.com/68551 8 # Under development: http://crbug.com/68551
9 'use_harfbuzz_ng%': 0 9 'use_harfbuzz_ng%': 0
10 }, 10 },
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 'conditions': [ 53 'conditions': [
54 ['OS == "android"', { 54 ['OS == "android"', {
55 'dependencies': [ 55 'dependencies': [
56 '../../third_party/freetype/freetype.gyp:ft2', 56 '../../third_party/freetype/freetype.gyp:ft2',
57 ], 57 ],
58 }, { # OS != android 58 }, { # OS != android
59 'dependencies': [ 59 'dependencies': [
60 '../../build/linux/system.gyp:freetype2', 60 '../../build/linux/system.gyp:freetype2',
61 ], 61 ],
62 }], 62 }],
63 ['OS == "android" and clang == 0', {
64 # The Android NDK compilers in the GCC 4.2 and 4.6 toolchains will
65 # show a warning about incompatible pointer signedness, but this
66 # warning cannot be disabled through an individual flag. To stop
67 # showing it, disable all warnings. Coverage is provided through
68 # clang builders, as well as Linux non-clang builders.
69 # TODO(beverloo): Re-enable warnings once the toolchains provide a
70 # way of disabling the specific warning.
71 'cflags_c': [
72 '-w',
Nico 2012/08/16 15:06:10 nit: unless gcc emits this warning only for c file
73 ],
74 }],
63 ['clang == 1', { 75 ['clang == 1', {
64 'xcode_settings': { 76 'xcode_settings': {
65 'WARNING_CFLAGS': [ 77 'WARNING_CFLAGS': [
66 # "harfbuzz is in strict maintenace mode", 78 # "harfbuzz is in strict maintenace mode",
67 # see http://crbug.com/113708 79 # see http://crbug.com/113708
68 '-Wno-pointer-sign', 80 '-Wno-pointer-sign',
69 ], 81 ],
70 }, 82 },
71 'cflags': [ 83 'cflags': [
72 '-Wno-pointer-sign', 84 '-Wno-pointer-sign',
(...skipping 13 matching lines...) Expand all
86 '../harfbuzz-ng/harfbuzz.gyp:harfbuzz-ng' 98 '../harfbuzz-ng/harfbuzz.gyp:harfbuzz-ng'
87 ], 99 ],
88 'export_dependent_settings': [ 100 'export_dependent_settings': [
89 '../harfbuzz-ng/harfbuzz.gyp:harfbuzz-ng' 101 '../harfbuzz-ng/harfbuzz.gyp:harfbuzz-ng'
90 ], 102 ],
91 } 103 }
92 ] 104 ]
93 }] 105 }]
94 ] 106 ]
95 } 107 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698