Issue 10829349: SPDY - Handle incomplete headers during server push.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829349: SPDY - Handle incomplete headers during server push. (Closed)

Created:
8 years, 4 months ago by ramant (doing other things)

Modified:
8 years, 4 months ago

Reviewers:
scarybeast, scarybeasts, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/branches/1180/src/

Visibility:
Public.

More Reviews

Description

SPDY - Handle incomplete headers during server push. Small fix to check for headers before accessing them. Original review URL: https://chromiumcodereview.appspot.com/10832170/ R=scarybeasts@gmail.com, rch@chromium.org BUG=135485 TEST=network unit tests and accessing https://jetty.intalio.com:10111/spdy/ crashes the browser on Linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152353

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	net/http/http_network_transaction.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

Hi scarybeast@, Submitting a separate CL from a checked out M21 branch for submitting to ...

8 years, 4 months ago (2012-08-15 23:08:07 UTC) #1

ramant (doing other things)

Hi Ryan, This is the same CL as the one you had approved before. Would ...

8 years, 4 months ago (2012-08-16 02:24:42 UTC) #2

Ryan Hamilton

8 years, 4 months ago (2012-08-20 16:51:13 UTC) #3

On 2012/08/16 02:24:42, ramant wrote:
> Hi Ryan,
>   This is the same CL as the one you had approved before. Would like to merge
> this change into M21 (the change was approved for merge).
> 
> thanks
> raman

LGTM.  Sorry, I was out Thursday and Friday.

Expand Messages | Collapse Messages