Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 10829298: Allow invocation of --multi-install without a product if App Host needs binaries. (Closed)

Created:
8 years, 4 months ago by erikwright (departed)
Modified:
8 years, 4 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Allow invocation of --multi-install without a product if App Host needs binaries. The installer will update the app host and install the binaries if only the app host is present at user-level and neither Chrome nor Binaries are present at system-level. R=robertshield BUG=138313 TEST=Install Chrome at system level, apps at user level. Uninstall chrome, then run 'setup.exe --multi-install --verbose-logging' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151283

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M chrome/installer/setup/setup_main.cc View 2 chunks +18 lines, -12 lines 0 comments Download
M chrome/installer/util/installer_state.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
erikwright (departed)
8 years, 4 months ago (2012-08-13 13:43:34 UTC) #1
robertshield
lgtm
8 years, 4 months ago (2012-08-13 14:06:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/10829298/1
8 years, 4 months ago (2012-08-13 15:06:02 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-13 16:31:57 UTC) #4
Change committed as 151283

Powered by Google App Engine
This is Rietveld 408576698