Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: chrome/installer/setup/setup_main.cc

Issue 10829298: Allow invocation of --multi-install without a product if App Host needs binaries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/util/installer_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/setup_main.cc
diff --git a/chrome/installer/setup/setup_main.cc b/chrome/installer/setup/setup_main.cc
index 95490b029e6811753a12c4a130e0a8a913acd3f5..139b8274e9eb5c81aba8e38593fc0d1b12a05436 100644
--- a/chrome/installer/setup/setup_main.cc
+++ b/chrome/installer/setup/setup_main.cc
@@ -360,6 +360,15 @@ bool CheckMultiInstallConditions(const InstallationState& original_state,
BrowserDistribution::CHROME_BROWSER);
if (!binaries) {
+ // This will only be hit if --multi-install is given with no products, or
+ // if the app host is being installed and doesn't need the binaries at
+ // user-level.
+ // The former case might be due to a request by an orphaned Application
+ // Host to re-install the binaries. Thus we add them to the installation.
+ // The latter case is fine and we let it be.
+ // If this is not an app host install and the binaries are not already
+ // present, the installation will fail later due to a lack of products to
+ // install.
if (app_host && !chrome && !chrome_frame && !cf_state && !chrome_state) {
DCHECK(!system_level);
// App Host may use Chrome/Chrome binaries at system-level.
@@ -370,23 +379,20 @@ bool CheckMultiInstallConditions(const InstallationState& original_state,
true, // system
BrowserDistribution::CHROME_BINARIES)) {
VLOG(1) << "Installing/updating Application Host without binaries.";
- return true;
} else {
// Somehow the binaries were present when the quick-enable app host
// command was run, but now they appear to be missing.
- // TODO(erikwright): should the binaries be implicitly added?
- LOG(ERROR) << "Cannot install Application Host without binaries.";
- *status = installer::APP_HOST_REQUIRES_BINARIES;
- installer_state->WriteInstallerResult(*status, 0, NULL);
- return false;
+ // Force binaries to be installed/updated.
+ scoped_ptr<Product> binaries_to_add(new Product(
+ BrowserDistribution::GetSpecificDistribution(
+ BrowserDistribution::CHROME_BINARIES)));
+ binaries_to_add->SetOption(installer::kOptionMultiInstall, true);
+ binaries = installer_state->AddProduct(&binaries_to_add);
+ VLOG(1) << "Adding binaries for pre-existing App Host installation.";
}
- } else {
- // Every other scenario requires the binaries to be installed/updated
- // along with the main product. This will only be hit if
- // --multi-install is given with no products. See
- // CheckPreInstallConditions for handling of this case.
- return true;
}
+
+ return true;
}
if (chrome) {
« no previous file with comments | « no previous file | chrome/installer/util/installer_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698