Issue 10829296: Revert 151110 - Fix ninja build for Android after http://codereview.chromium.org/10836080/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829296: Revert 151110 - Fix ninja build for Android after http://codereview.chromium.org/10836080/ (Closed)

Created:
8 years, 4 months ago by Peter Beverloo

Modified:
8 years, 4 months ago

Reviewers:
Yaron

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 151110 - Fix ninja build for Android after http://codereview.chromium.org/10836080/ This CL broke the WebKit Android build bot and EWS bots by exporting CC and CXX, which caused the global make settings as defined in gyp to be ignored. Original review URL: https://chromiumcodereview.appspot.com/10836192 TBR=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151251

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	build/android/envsetup.sh	View		1 chunk	+4 lines, -7 lines	0 comments	Download

Total messages: 1 (0 generated)