Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 10836192: Fix ninja build for Android after http://codereview.chromium.org/10836080/ (Closed)

Created:
8 years, 4 months ago by Yaron
Modified:
8 years, 4 months ago
Reviewers:
michaelbai, Nico
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org
Visibility:
Public.

Description

Fix ninja build for Android after http://codereview.chromium.org/10836080/ CC/CXX/AR now refer to target compilation. We need to specifically set the host toolchain (CC_host, CX_host, AR_host) as well. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M build/android/envsetup.sh View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yaron
8 years, 4 months ago (2012-08-10 18:06:18 UTC) #1
michaelbai
lgtm
8 years, 4 months ago (2012-08-10 18:07:30 UTC) #2
michaelbai
Are we plan to setup the ninja bot in upstream
8 years, 4 months ago (2012-08-10 18:11:10 UTC) #3
Yaron
On 2012/08/10 18:11:10, michaelbai wrote: > Are we plan to setup the ninja bot in ...
8 years, 4 months ago (2012-08-10 18:11:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10836192/1
8 years, 4 months ago (2012-08-10 18:12:57 UTC) #5
commit-bot: I haz the power
Try job failure for 10836192-1 on linux_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=46640 Step "update" is always ...
8 years, 4 months ago (2012-08-10 18:24:56 UTC) #6
Nico
8 years, 4 months ago (2012-08-10 19:06:55 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698