Every VisitItem returned by chrome.history.getVisits has link transition

Every VisitItem returned by chrome.history.getVisits has link transition

This was caused by a refactor to use the JSC (crrev.com/148166). I apologize for being so careless
and thank you mihaip for catching the problem so quickly.

BUG=140792
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151183

[brettw, 2012-08-10 04:32:10]

lgtm

[commit-bot: I haz the power, 2012-08-10 17:22:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10829273/1

[Mihai Parparita -not on Chrome, 2012-08-10 17:30:48]

https://chromiumcodereview.appspot.com/10829273/diff/1/chrome/browser/history...
File chrome/browser/history/history_extension_api.cc (right):

https://chromiumcodereview.appspot.com/10829273/diff/1/chrome/browser/history...
chrome/browser/history/history_extension_api.cc:71: const char* trans =
Nit: this variable is unused (and the DCHECK on the result is equivalent to the
DCHECK on line 111).

[mitchellwrosen, 2012-08-10 17:34:44]

On 2012/08/10 17:30:48, Mihai Parparita wrote:
>
https://chromiumcodereview.appspot.com/10829273/diff/1/chrome/browser/history...
> File chrome/browser/history/history_extension_api.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10829273/diff/1/chrome/browser/history...
> chrome/browser/history/history_extension_api.cc:71: const char* trans =
> Nit: this variable is unused (and the DCHECK on the result is equivalent to
the
> DCHECK on line 111).

Jumped the gun on that one, sorry. Okay to commit now?

[Mihai Parparita -not on Chrome, 2012-08-10 17:36:03]

LGTM

[commit-bot: I haz the power, 2012-08-10 17:36:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10829273/9003

[commit-bot: I haz the power, 2012-08-10 18:29:21]

Try job failure for 10829273-9003 (retry) on linux_rel for step "update".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-08-10 18:39:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10829273/8003

[commit-bot: I haz the power, 2012-08-10 18:47:18]

Try job failure for 10829273-8003 on linux_chromeos for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-08-11 01:07:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10829273/4005

[commit-bot: I haz the power, 2012-08-11 03:05:54]

Change committed as 151183