Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: chrome/browser/history/history_extension_api.cc

Issue 10829273: Every VisitItem returned by chrome.history.getVisits has link transition (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_extension_api.cc
diff --git a/chrome/browser/history/history_extension_api.cc b/chrome/browser/history/history_extension_api.cc
index 54d77939cd02ae0d7b6daf6c010d22196fd019c1..96d2e8a3123bec6dcfb61cce1792d35d535fcaeb 100644
--- a/chrome/browser/history/history_extension_api.cc
+++ b/chrome/browser/history/history_extension_api.cc
@@ -68,12 +68,8 @@ scoped_ptr<VisitItem> GetVisitItem(const history::VisitRow& row) {
new double(MilliSecondsFromTime(row.visit_time)));
visit_item->referring_visit_id = base::Int64ToString(row.referring_visit);
- const char* trans =
- content::PageTransitionGetCoreTransitionString(row.transition);
- DCHECK(trans) << "Invalid transition.";
-
VisitItem::Transition transition = VisitItem::TRANSITION_LINK;
- switch (row.transition) {
+ switch (row.transition & content::PAGE_TRANSITION_CORE_MASK) {
case content::PAGE_TRANSITION_LINK:
transition = VisitItem::TRANSITION_LINK;
break;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698