Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 10829247: contacts: Defer updates when offline. (Closed)

Created:
8 years, 4 months ago by Daniel Erat
Modified:
8 years, 4 months ago
Reviewers:
satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, derat+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

contacts: Defer updates when offline. This make GoogleContactStore postpone trying to update contacts via GData when the system doesn't have a network connection. BUG=128805 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150643

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -3 lines) Patch
M chrome/browser/chromeos/contacts/google_contact_store.h View 5 chunks +19 lines, -1 line 1 comment Download
M chrome/browser/chromeos/contacts/google_contact_store.cc View 3 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/contacts/google_contact_store_unittest.cc View 4 chunks +35 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_contacts_service_stub.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_contacts_service_stub.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Erat
8 years, 4 months ago (2012-08-08 20:57:58 UTC) #1
satorux1
LGTM http://codereview.chromium.org/10829247/diff/1/chrome/browser/chromeos/contacts/google_contact_store.h File chrome/browser/chromeos/contacts/google_contact_store.h (right): http://codereview.chromium.org/10829247/diff/1/chrome/browser/chromeos/contacts/google_contact_store.h#newcode40 chrome/browser/chromeos/contacts/google_contact_store.h:40: public net::NetworkChangeNotifier::ConnectionTypeObserver { I didn't know about this. ...
8 years, 4 months ago (2012-08-08 21:42:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10829247/1
8 years, 4 months ago (2012-08-08 21:45:27 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 00:08:36 UTC) #4
Change committed as 150643

Powered by Google App Engine
This is Rietveld 408576698