contacts: Defer updates when offline.

chrome/browser/chromeos/contacts/google_contact_store_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/contacts/google_contact_store.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/time.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/browser/chromeos/contacts/contact.pb.h"
 #include "chrome/browser/chromeos/contacts/contact_store_observer.h"
 #include "chrome/browser/chromeos/contacts/contact_test_util.h"
 #include "chrome/browser/chromeos/contacts/fake_contact_database.h"
 #include "chrome/browser/chromeos/gdata/gdata_contacts_service_stub.h"
 #include "chrome/browser/chromeos/gdata/gdata_util.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/test/test_browser_thread.h"
+#include "net/base/network_change_notifier.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using content::BrowserThread;
 
 namespace contacts {
 namespace test {
 
 // ContactStoreObserver implementation that just counts the number of times
 // that it's been told that a store has been updated.
 class TestContactStoreObserver : public ContactStoreObserver {
@@ skipping 18 matching lines @@
 };
 
 class GoogleContactStoreTest : public testing::Test {
  public:
   GoogleContactStoreTest() : ui_thread_(BrowserThread::UI, &message_loop_) {}
   virtual ~GoogleContactStoreTest() {}
 
  protected:
   // testing::Test implementation.
   virtual void SetUp() OVERRIDE {
-    testing::Test::SetUp();
+    // Create a mock NetworkChangeNotifier so the store won't be notified about
+    // changes to the system's actual network state.
+    network_change_notifier_.reset(net::NetworkChangeNotifier::CreateMock());
     profile_.reset(new TestingProfile);
 
     store_.reset(new GoogleContactStore(profile_.get()));
     store_->AddObserver(&observer_);
 
     test_api_.reset(new GoogleContactStore::TestAPI(store_.get()));
 
     db_ = new FakeContactDatabase;
     test_api_->SetDatabase(db_);
 
     gdata_service_ = new gdata::GDataContactsServiceStub;
     test_api_->SetGDataService(gdata_service_);
   }
 
   MessageLoopForUI message_loop_;
   content::TestBrowserThread ui_thread_;
 
   TestContactStoreObserver observer_;
+  scoped_ptr<net::NetworkChangeNotifier> network_change_notifier_;
   scoped_ptr<TestingProfile> profile_;
   scoped_ptr<GoogleContactStore> store_;
   scoped_ptr<GoogleContactStore::TestAPI> test_api_;
 
   FakeContactDatabase* db_;  // not owned
   gdata::GDataContactsServiceStub* gdata_service_;  // not owned
 
  private:
   DISALLOW_COPY_AND_ASSIGN(GoogleContactStoreTest);
 };
@@ skipping 283 matching lines @@
   // initialization failed) but we should still fetch the second one from GData
   // and schedule an update.
   store_->Init();
   ContactPointers loaded_contacts;
   store_->AppendContacts(&loaded_contacts);
   EXPECT_EQ(ContactsToString(gdata_contacts),
             ContactsToString(loaded_contacts));
   EXPECT_TRUE(test_api_->update_scheduled());
 }
 
+TEST_F(GoogleContactStoreTest, AvoidUpdatesWhenOffline) {
+  EXPECT_EQ(0, gdata_service_->num_download_requests());
+
+  // Notify the store that we're offline.  Init() shouldn't attempt an update
+  // and the update timer shouldn't be running.
+  test_api_->NotifyAboutNetworkStateChange(false);
+  store_->Init();
+  EXPECT_EQ(0, gdata_service_->num_download_requests());
+  EXPECT_FALSE(test_api_->update_scheduled());
+
+  // We should do an update and schedule further updates as soon as we go
+  // online.
+  gdata_service_->reset_stats();
+  test_api_->NotifyAboutNetworkStateChange(true);
+  EXPECT_EQ(1, gdata_service_->num_download_requests());
+  EXPECT_TRUE(test_api_->update_scheduled());
+
+  // If we call DoUpdate() to mimic the code path that's used for a timer-driven
+  // update while we're offline, we should again defer the update.
+  gdata_service_->reset_stats();
+  test_api_->NotifyAboutNetworkStateChange(false);
+  test_api_->DoUpdate();
+  EXPECT_EQ(0, gdata_service_->num_download_requests());
+
+  // When we're back online, the update should happen.
+  gdata_service_->reset_stats();
+  test_api_->NotifyAboutNetworkStateChange(true);
+  EXPECT_EQ(1, gdata_service_->num_download_requests());
+}
+
 }  // namespace test
 }  // namespace contacts