Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Unified Diff: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ScriptMappingTab.java

Issue 10829181: Redesign TabBase to get rid of mandatory inheritance of dialog element interfaces (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: fcr Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ScriptMappingTab.java
diff --git a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ScriptMappingTab.java b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ScriptMappingTab.java
index 3f97e969fc420c09b8c82d2d5c8189701b9841dc..d22a91c10a33554457ce35bb66016eef0ad48817 100644
--- a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ScriptMappingTab.java
+++ b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ScriptMappingTab.java
@@ -362,11 +362,11 @@ public class ScriptMappingTab extends TabBase<ScriptMappingTab.Elements, Params>
return null;
}
- protected List<? extends TabField<?, ?, Elements, Params>> getTabFields() {
+ protected TabFieldList<Elements, Params> getTabFields() {
return TAB_FIELDS;
}
- static final List<? extends TabField<?, ?, Elements, Params>> TAB_FIELDS;
+ static final TabFieldList<Elements, Params> TAB_FIELDS;
static {
List<TabField<?, ?, Elements, Params>> list =
new ArrayList<ChromiumRemoteTab.TabField<?, ?, Elements, Params>>(4);
@@ -427,6 +427,6 @@ public class ScriptMappingTab extends TabBase<ScriptMappingTab.Elements, Params>
},
LaunchParams.PredefinedSourceWrapperIds.CONVERTER));
- TAB_FIELDS = Collections.unmodifiableList(list);
+ TAB_FIELDS = createFieldListImpl(list);
}
}

Powered by Google App Engine
This is Rietveld 408576698