Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ChromiumRemoteTab.java

Issue 10829181: Redesign TabBase to get rid of mandatory inheritance of dialog element interfaces (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: fcr Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ScriptMappingTab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ChromiumRemoteTab.java
diff --git a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ChromiumRemoteTab.java b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ChromiumRemoteTab.java
index 8f7ae011f24c94e837f34009f95c43bca11b30f2..b679848276b6153df2cd0971ea6d77464a1fbb61 100755
--- a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ChromiumRemoteTab.java
+++ b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ChromiumRemoteTab.java
@@ -39,15 +39,12 @@ import org.eclipse.jface.preference.StringFieldEditor;
import org.eclipse.jface.util.IPropertyChangeListener;
import org.eclipse.jface.util.PropertyChangeEvent;
import org.eclipse.swt.SWT;
-import org.eclipse.swt.events.SelectionEvent;
-import org.eclipse.swt.events.SelectionListener;
import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout;
import org.eclipse.swt.widgets.Button;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Group;
-import org.eclipse.swt.widgets.Label;
/**
* The "Remote" tab for the Chromium JavaScript launch tab group.
@@ -234,9 +231,7 @@ public abstract class ChromiumRemoteTab<ELEMENTS> extends TabBase<ELEMENTS, Para
RadioButtonsLogic<Integer> getBreakpointRadioButtons();
}
- protected abstract List<? extends TabField<?, ?, ? super ELEMENTS, Params>> getTabFields();
-
- static final List<? extends TabField<?, ?, ? super TabElements, Params>> BASIC_TAB_FIELDS;
+ static final TabFieldList<TabElements, Params> BASIC_TAB_FIELDS;
static {
List<TabField<?, ?, ? super TabElements, Params>> list =
new ArrayList<ChromiumRemoteTab.TabField<?, ?, ? super TabElements, Params>>(4);
@@ -327,7 +322,7 @@ public abstract class ChromiumRemoteTab<ELEMENTS> extends TabBase<ELEMENTS, Para
},
ValueConverter.<String>getTrivial()));
- BASIC_TAB_FIELDS = Collections.unmodifiableList(list);
+ BASIC_TAB_FIELDS = createFieldListImpl(list);
}
private static class SourceContainerChecker {
@@ -393,7 +388,7 @@ public abstract class ChromiumRemoteTab<ELEMENTS> extends TabBase<ELEMENTS, Para
}
@Override
- protected List<? extends TabField<?, ?, ? super TabElements, Params>> getTabFields() {
+ protected TabFieldList<? super TabElements, ? super Params> getTabFields() {
return BASIC_TAB_FIELDS;
}
@@ -414,7 +409,7 @@ public abstract class ChromiumRemoteTab<ELEMENTS> extends TabBase<ELEMENTS, Para
}
@Override
- protected List<? extends TabField<?, ?, ? super TabElements, Params>> getTabFields() {
+ protected TabFieldList<? super TabElements, ? super Params> getTabFields() {
return BASIC_TAB_FIELDS;
}
« no previous file with comments | « no previous file | plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ScriptMappingTab.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698