Redesign TabBase to get rid of mandatory inheritance of dialog element interfaces

plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/launcher/ChromiumRemoteTab.java

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.debug.ui.launcher;
 
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
@@ skipping 21 matching lines @@
 import org.eclipse.debug.ui.DebugUITools;
 import org.eclipse.debug.ui.IDebugUIConstants;
 import org.eclipse.jface.preference.BooleanFieldEditor;
 import org.eclipse.jface.preference.FieldEditor;
 import org.eclipse.jface.preference.IntegerFieldEditor;
 import org.eclipse.jface.preference.PreferenceStore;
 import org.eclipse.jface.preference.StringFieldEditor;
 import org.eclipse.jface.util.IPropertyChangeListener;
 import org.eclipse.jface.util.PropertyChangeEvent;
 import org.eclipse.swt.SWT;
-import org.eclipse.swt.events.SelectionEvent;
-import org.eclipse.swt.events.SelectionListener;
 import org.eclipse.swt.graphics.Image;
 import org.eclipse.swt.layout.GridData;
 import org.eclipse.swt.layout.GridLayout;
 import org.eclipse.swt.widgets.Button;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Group;
-import org.eclipse.swt.widgets.Label;
 
 /**
  * The "Remote" tab for the Chromium JavaScript launch tab group.
  * @param <ELEMENTS> type used for access to created dialog elements; it is used internally
  *     and allows to subclass {@link ChromiumRemoteTab} with additional dialog controls
  */
 public abstract class ChromiumRemoteTab<ELEMENTS> extends TabBase<ELEMENTS, Params> {
   private static final String HOST_FIELD_NAME = "host_field"; //$NON-NLS-1$
   private static final String PORT_FIELD_NAME = "port_field"; //$NON-NLS-1$
   private static final String ADD_NETWORK_CONSOLE_FIELD_NAME =
@@ skipping 166 matching lines @@
     return DebugUITools.getImage(IDebugUIConstants.IMG_LCL_DISCONNECT);
   }
 
   interface TabElements {
     StringFieldEditor getHost();
     IntegerFieldEditor getPort();
     BooleanFieldEditor getAddNetworkConsole();
     RadioButtonsLogic<Integer> getBreakpointRadioButtons();
   }
 
-  protected abstract List<? extends TabField<?, ?, ? super ELEMENTS, Params>> getTabFields();
-
-  static final List<? extends TabField<?, ?, ? super TabElements, Params>> BASIC_TAB_FIELDS;
+  static final TabFieldList<TabElements, Params> BASIC_TAB_FIELDS;
   static {
     List<TabField<?, ?, ? super TabElements, Params>> list =
         new ArrayList<ChromiumRemoteTab.TabField<?, ?, ? super TabElements, Params>>(4);
 
     list.add(new TabField<String, String, TabElements, Params>(
         LaunchParams.CHROMIUM_DEBUG_HOST, TypedMethods.STRING,
         new FieldEditorAccess<String, TabElements>(TypedMethods.STRING) {
           @Override
           FieldEditor getFieldEditor(TabElements tabElements) {
             return tabElements.getHost();
@@ skipping 70 matching lines @@
         new DefaultsProvider<String, Params>() {
           @Override String getFallbackValue() {
             return Direction.MERGE.toString();
           }
           @Override String getInitialConfigValue(Params context) {
             return null;
           }
         },
         ValueConverter.<String>getTrivial()));
 
-    BASIC_TAB_FIELDS = Collections.unmodifiableList(list);
+    BASIC_TAB_FIELDS = createFieldListImpl(list);
   }
 
   private static class SourceContainerChecker {
     public String check(ILaunchConfiguration config) {
       LookupMode lookupMode;
       try {
         lookupMode = ChromiumSourceDirector.readLookupMode(config);
       } catch (CoreException e) {
         ChromiumDebugPlugin.log(e);
         return null;
@@ skipping 45 matching lines @@
       super(PARAMS);
     }
 
     @Override
     protected TabElements createDialogElements(Composite composite,
         Runnable modifyListener, PreferenceStore store) {
       return createBasicTabElements(composite, modifyListener, store, getParams());
     }
 
     @Override
-    protected List<? extends TabField<?, ?, ? super TabElements, Params>> getTabFields() {
+    protected TabFieldList<? super TabElements, ? super Params> getTabFields() {
       return BASIC_TAB_FIELDS;
     }
 
     private static final Params PARAMS = new Params(
         ChromiumRemoteTab.HostChecker.LOCAL_ONLY,
         Messages.ChromiumRemoteTab_URL, false);
   }
 
   static class Standalone extends ChromiumRemoteTab<TabElements> {
     public Standalone() {
       super(PARAMS);
     }
 
     @Override
     protected TabElements createDialogElements(Composite composite,
         Runnable modifyListener, PreferenceStore store) {
       return createBasicTabElements(composite, modifyListener, store, getParams());
     }
 
     @Override
-    protected List<? extends TabField<?, ?, ? super TabElements, Params>> getTabFields() {
+    protected TabFieldList<? super TabElements, ? super Params> getTabFields() {
       return BASIC_TAB_FIELDS;
     }
 
     private static final Params PARAMS = new Params(null,
         Messages.ChromiumRemoteTab_FILE_PATH, true);
   }
 }