Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(53)

Issue 10829122: android: refine custom ucontext_t definitions. (Closed)

Created:
8 years ago by digit1
Modified:
8 years ago
Reviewers:
Sven Panne, ulan, danno, Yang
CC:
v8-dev
Visibility:
Public.

Description

android: refine custom ucontext_t definitions. This is a forward-compatible change to avoid type/naming conflicts when the Android platform/NDK will update its <signal.h> header to properly define 'struct sigcontext', 'mcontext_t' and 'ucontext_t'. In particular: - Do not define 'struct sigcontext.h' to avoid conflicts with the C library definition (which is different, see below). - Only provide custom ucontext_t declarations if the Android <signal.h> doesn't provide it. This can be tested with a macro check (__BIONIC_HAVE_UCONTEXT_T) + Use 'gettid()' on Android since it is available (at all API levels). See http://code.google.com/p/android/issues/detail?id=34784 Committed: https://code.google.com/p/v8/source/detail?r=12250

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -34 lines) Patch
M src/platform-linux.cc View 4 chunks +39 lines, -34 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sven Panne
LGTM, although I had to make some minor modifications to make presubmit.py and GCC totally ...
8 years ago (2012-08-02 10:01:23 UTC) #1
digit1
8 years ago (2012-08-02 10:48:18 UTC) #2
Thanks a ton :)

Powered by Google App Engine
This is Rietveld 408576698