Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 10829065: Remove InputMethodManager::EnableHotkeys() and DisableHotkeys(). (Closed)

Created:
8 years, 4 months ago by Yusuke Sato
Modified:
8 years, 4 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove InputMethodManager::EnableHotkeys() and DisableHotkeys(). They're no longer necessary as crbug.com/129834 is implemented. BUG=None TEST=try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -57 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 4 chunks +1 line, -19 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
8 years, 4 months ago (2012-07-27 22:15:28 UTC) #1
Seigo Nonaka
lgtm
8 years, 4 months ago (2012-07-30 04:36:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10829065/1
8 years, 4 months ago (2012-07-30 04:42:24 UTC) #3
commit-bot: I haz the power
Presubmit check for 10829065-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-30 04:42:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10829065/1
8 years, 4 months ago (2012-07-30 14:47:26 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 16:08:54 UTC) #6
Change committed as 148957

Powered by Google App Engine
This is Rietveld 408576698