chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc - Issue 10829065: Remove InputMethodManager::EnableHotkeys() and DisableHotkeys().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

Issue 10829065: Remove InputMethodManager::EnableHotkeys() and DisableHotkeys(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_manager_impl.cc ('k') | chrome/browser/chromeos/input_method/mock_input_method_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

index f60b73540684839840756dd4a47900cd28ed1f41..89a1f87bb60f363c7ef81e26171bef8a2d927cb6 100644

--- a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

@@ -789,23 +789,6 @@ TEST_F(InputMethodManagerImplTest, TestSwitchInputMethodWithKoIme) {

EXPECT_EQ("xkb:kr:kr104:kor", manager_->GetCurrentInputMethod().id());

}

-TEST_F(InputMethodManagerImplTest, TestEnableDisableHotkeys) {

- manager_->EnableLayouts("ja", "xkb:us::eng");

- EXPECT_EQ(2U, manager_->GetNumActiveInputMethods());

- EXPECT_EQ("xkb:us::eng", manager_->GetCurrentInputMethod().id());

- manager_->DisableHotkeys();

- EXPECT_FALSE(manager_->SwitchToNextInputMethod());

- EXPECT_EQ("xkb:us::eng", manager_->GetCurrentInputMethod().id());

- EXPECT_FALSE(manager_->SwitchToPreviousInputMethod());

- EXPECT_EQ("xkb:us::eng", manager_->GetCurrentInputMethod().id());

- EXPECT_FALSE(manager_->SwitchInputMethod(

- ui::Accelerator(ui::VKEY_NONCONVERT, ui::EF_NONE)));

- EXPECT_EQ("xkb:us::eng", manager_->GetCurrentInputMethod().id());

- manager_->EnableHotkeys();

- EXPECT_TRUE(manager_->SwitchToNextInputMethod());

- EXPECT_NE("xkb:us::eng", manager_->GetCurrentInputMethod().id());

TEST_F(InputMethodManagerImplTest, TestAddRemoveExtensionInputMethods) {

TestObserver observer;

manager_->AddObserver(&observer);