Chromium Code Reviews| Index: pylib/gyp/generator/msvs.py |
| =================================================================== |
| --- pylib/gyp/generator/msvs.py (revision 1440) |
| +++ pylib/gyp/generator/msvs.py (working copy) |
| @@ -295,8 +295,11 @@ |
| else: |
| command = [cmd[0].replace('/', '\\')] |
| # Fix the paths |
| - # If the argument starts with a slash, it's probably a command line switch |
| - arguments = [i.startswith('/') and i or _FixPath(i) for i in cmd[1:]] |
| + # TODO(quote): This is a really ugly heuristic, and will miss path fixing |
| + # for arguments like "--arg=path" or "/opt:path". |
| + # If the argument starts with a slash or dash, it's probably a command line |
| + # switch |
| + arguments = [i if (i[:1] in "/-") else _FixPath(i) for i in cmd[1:]] |
|
scottmg
2012/07/27 00:31:49
i[0] instead of i[:1]
|
| arguments = [i.replace('$(InputDir)','%INPUTDIR%') for i in arguments] |
| if quote_cmd: |
| # Support a mode for using cmd directly. |