Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 10829007: Revert 148281 - Remove details from BROWSER_CLOSING and BROWSER_CLOSED notifications. (Closed)

Created:
8 years, 5 months ago by benwells
Modified:
8 years, 5 months ago
Reviewers:
benwells
CC:
chromium-reviews, robertshield, rginda+watch_chromium.org, kkania
Visibility:
Public.

Description

Revert 148281 - Remove details from BROWSER_CLOSING and BROWSER_CLOSED notifications. The details was a boolean indicating whether this is the last browser window closing. As part of this change the logic for saving pinned tabs has been changed to not use the boolean in the details, and has been updated to handle the case where a user exit or closing of the last window is cancelled by an onbeforeunload event. Also as part of this change, both the pinned tab and multi profile features have been updated to handle cases of the browser process not being closed due to background mode or (in the future) packaged apps, and then more browser windows being opened. BUG=None TEST=Test shutdown Review URL: https://chromiumcodereview.appspot.com/10800031 TBR=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -57 lines) Patch
M chrome/browser/automation/automation_provider_observers.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_list_impl.cc View 1 chunk +19 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_service.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/tabs/pinned_tab_service.cc View 6 chunks +17 lines, -38 lines 0 comments Download
M chrome/common/automation_messages_internal.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/common/chrome_notification_types.h View 1 chunk +11 lines, -4 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
benwells
8 years, 5 months ago (2012-07-25 03:41:15 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698