Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8562)

Unified Diff: chrome/common/chrome_notification_types.h

Issue 10829007: Revert 148281 - Remove details from BROWSER_CLOSING and BROWSER_CLOSED notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/automation_messages_internal.h ('k') | chrome/test/ui/ui_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_notification_types.h
===================================================================
--- chrome/common/chrome_notification_types.h (revision 148288)
+++ chrome/common/chrome_notification_types.h (working copy)
@@ -25,13 +25,20 @@
NOTIFICATION_BROWSER_WINDOW_READY,
// This message is sent when a browser is closing. The source is a
- // Source<Browser> containing the affected Browser. No details are expected.
- // This is sent prior to BROWSER_CLOSED, and may be sent more than once for a
- // particular browser.
+ // Source<Browser> containing the affected Browser. Details is a boolean
+ // that if true indicates that the application will be closed as a result of
+ // this browser window closure (i.e. this was the last opened browser
+ // window on win/linux). This is sent prior to BROWSER_CLOSED, and may be
+ // sent more than once for a particular browser.
NOTIFICATION_BROWSER_CLOSING,
// This message is sent after a window has been closed. The source is a
- // Source<Browser> containing the affected Browser. No details are exptected.
+ // Source<Browser> containing the affected Browser. Details is a boolean
+ // that if true indicates that the last browser window has closed - this
+ // does not indicate that the application is exiting (observers should
+ // listen for APP_TERMINATING if they want to detect when the application
+ // will shut down). Note that the boolean pointed to by details is only
+ // valid for the duration of this call.
NOTIFICATION_BROWSER_CLOSED,
// This message is sent when closing a browser has been cancelled, either by
« no previous file with comments | « chrome/common/automation_messages_internal.h ('k') | chrome/test/ui/ui_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698