Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 10828381: libcc and webkit_compositor targets + stubs (Closed)

Created:
8 years, 4 months ago by jamesr
Modified:
8 years, 4 months ago
Reviewers:
nduca
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Here are gyp targets and stubs for compiling libcc and the webkit_compositor bindings in chromium. Everything is guarded behind the off-by-default use_libcc_for_compositor gyp variable. I haven't included the actual code here, but there are scripts to sync. I plan to land + manually sync the code into place until we're ready to flip the gyp switch. Snapshot from r126652 BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153354

Patch Set 1 #

Patch Set 2 : cleaned up #

Patch Set 3 : #

Patch Set 4 : Slightly better scripts and updated README #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+820 lines, -5 lines) Patch
M PRESUBMIT.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M build/all.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A cc/DEPS View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M cc/README View 1 2 3 1 chunk +17 lines, -2 lines 0 comments Download
M cc/cc.gyp View 1 2 1 chunk +238 lines, -3 lines 0 comments Download
A cc/cc_tests.gyp View 1 2 1 chunk +105 lines, -0 lines 0 comments Download
A cc/copyfiles.py View 1 2 3 1 chunk +52 lines, -0 lines 0 comments Download
A cc/stubs/Extensions3D.h View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A cc/stubs/Extensions3DChromium.h View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
A cc/stubs/GraphicsContext3D.h View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A cc/stubs/GraphicsTypes3D.h View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A cc/stubs/NotImplemented.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A cc/stubs/Region.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A cc/stubs/SkiaUtils.h View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A cc/stubs/TextStream.h View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A cc/stubs/TilingData.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A cc/stubs/TraceEvent.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A cc/stubs/UnitBezier.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A cc/test/RunAllTests.cpp View 1 2 1 chunk +48 lines, -0 lines 2 comments Download
A webkit/compositor/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A webkit/compositor/compositor.gyp View 1 2 1 chunk +80 lines, -0 lines 0 comments Download
A webkit/compositor/copyfiles.py View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download
A webkit/compositor/stubs/AnimationIdVendor.h View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/compositor/stubs/public/WebTransformationMatrix.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
I think we're ready to go here, Nat!
8 years, 4 months ago (2012-08-24 05:58:30 UTC) #1
nduca
Agreed, this is so cool. LGTM with a minor test comment. http://codereview.chromium.org/10828381/diff/10001/cc/test/RunAllTests.cpp File cc/test/RunAllTests.cpp (right): ...
8 years, 4 months ago (2012-08-24 20:15:05 UTC) #2
jamesr
http://codereview.chromium.org/10828381/diff/10001/cc/test/RunAllTests.cpp File cc/test/RunAllTests.cpp (right): http://codereview.chromium.org/10828381/diff/10001/cc/test/RunAllTests.cpp#newcode41 cc/test/RunAllTests.cpp:41: ::testing::InitGoogleMock(&argc, argv); On 2012/08/24 20:15:05, nduca wrote: > Would ...
8 years, 4 months ago (2012-08-24 20:31:57 UTC) #3
jamesr
8 years, 4 months ago (2012-08-24 20:33:49 UTC) #4
And I need to generate proper copyright headers on new files. Whee!

Powered by Google App Engine
This is Rietveld 408576698