Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 10828352: [Chromoting] Avoid potential conflicts leading to pending reboots while upgrading the me2me host: (Closed)

Created:
8 years, 4 months ago by alexeypa (please no reviews)
Modified:
8 years, 4 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Avoid potential conflicts leading to pending reboots while upgrading the me2me host: - Install the host binaries to versioned folders. - Drop references to the COM objects quickly. - Auto-generate CLSID of the daemon controller at GYP time. This makes sure that a freshly installed version of the controller will be launched after upgrade even if there is already running instance cached by RPCSS. This CL restores https://chromiumcodereview.appspot.com/10831037 (r148671) and https://chromiumcodereview.appspot.com/10837087 (r149866) previously reverted by r150494. Unlike the previous two CLs this one does not require GYP changes (that is changes to GYP itself, not .gyp files). BUG=137755 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152120

Patch Set 1 #

Total comments: 4

Patch Set 2 : CR feedback #

Patch Set 3 : Do not concatenate absolute paths. #

Patch Set 4 : rebased #

Patch Set 5 : Made compilable and rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -96 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/plugin/daemon_controller_win.cc View 3 chunks +19 lines, -3 lines 0 comments Download
M remoting/host/win/chromoting.wxs View 5 chunks +14 lines, -6 lines 0 comments Download
M remoting/host/win/elevated_controller.h View 2 chunks +4 lines, -3 lines 0 comments Download
D remoting/host/win/elevated_controller.idl View 1 chunk +0 lines, -82 lines 0 comments Download
A remoting/host/win/elevated_controller_idl.templ View 1 chunk +82 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 4 5 chunks +28 lines, -2 lines 0 comments Download
M remoting/tools/candle_and_light.py View 2 chunks +2 lines, -0 lines 0 comments Download
A remoting/tools/uuidgen.py View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
alexeypa (please no reviews)
PTAL.
8 years, 4 months ago (2012-08-16 17:53:47 UTC) #1
Jamie
LGTM with nits, but please update the CL description, which currently says that no gyp ...
8 years, 4 months ago (2012-08-16 18:18:46 UTC) #2
alexeypa (please no reviews)
> but please update the CL description, which currently says that no gyp changes are ...
8 years, 4 months ago (2012-08-16 18:35:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10828352/6005
8 years, 4 months ago (2012-08-16 23:02:26 UTC) #4
commit-bot: I haz the power
Try job failure for 10828352-6005 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-17 00:41:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10828352/13
8 years, 4 months ago (2012-08-17 15:29:31 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 18:42:01 UTC) #7
Change committed as 152120

Powered by Google App Engine
This is Rietveld 408576698