Issue 10837087: [Chromoting] Auto-generate CLSID of the daemon controller at GYP time. This makes sure that a fresh…

Issue 10837087: [Chromoting] Auto-generate CLSID of the daemon controller at GYP time. This makes sure that a fresh… (Closed)

Created:
8 years, 4 months ago by alexeypa (please no reviews)

Modified:
8 years, 4 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Chromoting] Auto-generate CLSID of the daemon controller at GYP time. This makes sure that a freshly installed version of the controller will be launched after upgrade even if there is already running instance cached by RPCSS. BUG=137755 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149866

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -12 lines)			Patch
M	remoting/host/win/chromoting.wxs	View	1	4 chunks	+8 lines, -4 lines	0 comments	Download
M	remoting/host/win/elevated_controller.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	remoting/host/win/elevated_controller.idl	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/remoting.gyp	View	1	4 chunks	+11 lines, -0 lines	0 comments	Download
M	remoting/tools/candle_and_light.py	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
A +	remoting/tools/uuidgen.py	View		1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jamie

lgtm https://chromiumcodereview.appspot.com/10837087/diff/1/remoting/host/installer/chromoting.wxs File remoting/host/installer/chromoting.wxs (right): https://chromiumcodereview.appspot.com/10837087/diff/1/remoting/host/installer/chromoting.wxs#newcode227 remoting/host/installer/chromoting.wxs:227: Value="$(var.ControllerProgid).$(var.Version)"/> Is this part of this change or ...

8 years, 4 months ago (2012-08-03 00:31:19 UTC) #2

alexeypa (please no reviews)

FYI https://chromiumcodereview.appspot.com/10837087/diff/1/remoting/host/installer/chromoting.wxs File remoting/host/installer/chromoting.wxs (right): https://chromiumcodereview.appspot.com/10837087/diff/1/remoting/host/installer/chromoting.wxs#newcode227 remoting/host/installer/chromoting.wxs:227: Value="$(var.ControllerProgid).$(var.Version)"/> On 2012/08/03 00:31:19, Jamie wrote: > Is ...

8 years, 4 months ago (2012-08-03 01:09:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10837087/5001

8 years, 4 months ago (2012-08-03 15:50:15 UTC) #4

Change committed as 149866

Expand Messages | Collapse Messages