Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10828318: Disable using CompileType for class check elimination. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/intermediate_language.cc ('K') | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | runtime/vm/intermediate_language_x64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 10679)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -500,8 +500,10 @@
static intptr_t GetCid(const Value& v) {
- const AbstractType& type = AbstractType::Handle(v.CompileType());
- return Class::Handle(type.type_class()).id();
+ // TODO(srdjan): CompileType does not give us correct type for optimizations.
regis 2012/08/15 00:11:46 Does not guarantee that the receiver is not null.
srdjan 2012/08/15 00:16:46 That is the same.
+ // const AbstractType& type = AbstractType::Handle(v.CompileType());
+ // return Class::Handle(type.type_class()).id();
+ return kIllegalCid;
}
« runtime/vm/intermediate_language.cc ('K') | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | runtime/vm/intermediate_language_x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698