Chromium Code Reviews| Index: runtime/vm/intermediate_language.cc |
| =================================================================== |
| --- runtime/vm/intermediate_language.cc (revision 10687) |
| +++ runtime/vm/intermediate_language.cc (working copy) |
| @@ -1042,6 +1042,7 @@ |
| Definition* StrictCompareComp::TryReplace(BindInstr* instr) { |
| + // TODO(srdjan): Do not use CompileType, as it is not correct. |
|
regis
2012/08/15 00:11:46
CompileType is not wrong. As I explained, it just
srdjan
2012/08/15 00:16:46
Oops. I realized that and changed the text to:
|
| return NULL; |
| UseVal* left_use = left()->AsUse(); |
| UseVal* right_use = right()->AsUse(); |
| @@ -1053,7 +1054,6 @@ |
| if (right_constant == NULL) return NULL; |
| // TODO(fschneider): Handle other cases: e === false and e !== true/false. |
| // Handles e === true. |
| - // const AbstractType& left_type = AbstractType::Handle(left->CompileType()); |
| if ((kind() == Token::kEQ_STRICT) && |
| (right_constant->value().raw() == Bool::True()) && |
| left_use->CompileTypeIsMoreSpecificThan( |