Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: chrome/browser/automation/automation_provider_observers.cc

Issue 10828245: Final set of conversions of automation calls to the JSON interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/automation_provider_observers.cc
diff --git a/chrome/browser/automation/automation_provider_observers.cc b/chrome/browser/automation/automation_provider_observers.cc
index 19d9d4e4653656b87181cedc4e36ea81d47f5afa..07ac4cfb3fa106d984fdac4863121747fad52155 100644
--- a/chrome/browser/automation/automation_provider_observers.cc
+++ b/chrome/browser/automation/automation_provider_observers.cc
@@ -1403,10 +1403,12 @@ AutomationProviderBookmarkModelObserver::
AutomationProviderBookmarkModelObserver(
AutomationProvider* provider,
IPC::Message* reply_message,
- BookmarkModel* model)
+ BookmarkModel* model,
+ bool use_json_interface)
: automation_provider_(provider->AsWeakPtr()),
reply_message_(reply_message),
- model_(model) {
+ model_(model),
+ use_json_interface_(use_json_interface) {
model_->AddObserver(this);
}
@@ -1425,11 +1427,20 @@ void AutomationProviderBookmarkModelObserver::BookmarkModelBeingDeleted(
ReplyAndDelete(false);
}
+IPC::Message* AutomationProviderBookmarkModelObserver::ReleaseReply() {
+ return reply_message_.release();
+}
+
void AutomationProviderBookmarkModelObserver::ReplyAndDelete(bool success) {
if (automation_provider_) {
- AutomationMsg_WaitForBookmarkModelToLoad::WriteReplyParams(
- reply_message_.get(), success);
- automation_provider_->Send(reply_message_.release());
+ if (use_json_interface_) {
+ AutomationJSONReply(automation_provider_,
+ reply_message_.release()).SendSuccess(NULL);
+ } else {
+ AutomationMsg_WaitForBookmarkModelToLoad::WriteReplyParams(
+ reply_message_.get(), success);
+ automation_provider_->Send(reply_message_.release());
+ }
}
delete this;
}

Powered by Google App Engine
This is Rietveld 408576698