Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: chrome/browser/automation/automation_provider_observers.cc

Issue 10828245: Final set of conversions of automation calls to the JSON interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/automation/automation_provider_observers.h" 5 #include "chrome/browser/automation/automation_provider_observers.h"
6 6
7 #include <deque> 7 #include <deque>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 1385 matching lines...) Expand 10 before | Expand all | Expand 10 after
1396 true); 1396 true);
1397 automation_->Send(reply_message_.release()); 1397 automation_->Send(reply_message_.release());
1398 } 1398 }
1399 delete this; 1399 delete this;
1400 } 1400 }
1401 1401
1402 AutomationProviderBookmarkModelObserver:: 1402 AutomationProviderBookmarkModelObserver::
1403 AutomationProviderBookmarkModelObserver( 1403 AutomationProviderBookmarkModelObserver(
1404 AutomationProvider* provider, 1404 AutomationProvider* provider,
1405 IPC::Message* reply_message, 1405 IPC::Message* reply_message,
1406 BookmarkModel* model) 1406 BookmarkModel* model,
1407 bool use_json_interface)
1407 : automation_provider_(provider->AsWeakPtr()), 1408 : automation_provider_(provider->AsWeakPtr()),
1408 reply_message_(reply_message), 1409 reply_message_(reply_message),
1409 model_(model) { 1410 model_(model),
1411 use_json_interface_(use_json_interface) {
1410 model_->AddObserver(this); 1412 model_->AddObserver(this);
1411 } 1413 }
1412 1414
1413 AutomationProviderBookmarkModelObserver:: 1415 AutomationProviderBookmarkModelObserver::
1414 ~AutomationProviderBookmarkModelObserver() { 1416 ~AutomationProviderBookmarkModelObserver() {
1415 model_->RemoveObserver(this); 1417 model_->RemoveObserver(this);
1416 } 1418 }
1417 1419
1418 void AutomationProviderBookmarkModelObserver::Loaded(BookmarkModel* model, 1420 void AutomationProviderBookmarkModelObserver::Loaded(BookmarkModel* model,
1419 bool ids_reassigned) { 1421 bool ids_reassigned) {
1420 ReplyAndDelete(true); 1422 ReplyAndDelete(true);
1421 } 1423 }
1422 1424
1423 void AutomationProviderBookmarkModelObserver::BookmarkModelBeingDeleted( 1425 void AutomationProviderBookmarkModelObserver::BookmarkModelBeingDeleted(
1424 BookmarkModel* model) { 1426 BookmarkModel* model) {
1425 ReplyAndDelete(false); 1427 ReplyAndDelete(false);
1426 } 1428 }
1427 1429
1430 IPC::Message* AutomationProviderBookmarkModelObserver::ReleaseReply() {
1431 return reply_message_.release();
1432 }
1433
1428 void AutomationProviderBookmarkModelObserver::ReplyAndDelete(bool success) { 1434 void AutomationProviderBookmarkModelObserver::ReplyAndDelete(bool success) {
1429 if (automation_provider_) { 1435 if (automation_provider_) {
1430 AutomationMsg_WaitForBookmarkModelToLoad::WriteReplyParams( 1436 if (use_json_interface_) {
1431 reply_message_.get(), success); 1437 AutomationJSONReply(automation_provider_,
1432 automation_provider_->Send(reply_message_.release()); 1438 reply_message_.release()).SendSuccess(NULL);
1439 } else {
1440 AutomationMsg_WaitForBookmarkModelToLoad::WriteReplyParams(
1441 reply_message_.get(), success);
1442 automation_provider_->Send(reply_message_.release());
1443 }
1433 } 1444 }
1434 delete this; 1445 delete this;
1435 } 1446 }
1436 1447
1437 AutomationProviderDownloadUpdatedObserver:: 1448 AutomationProviderDownloadUpdatedObserver::
1438 AutomationProviderDownloadUpdatedObserver( 1449 AutomationProviderDownloadUpdatedObserver(
1439 AutomationProvider* provider, 1450 AutomationProvider* provider,
1440 IPC::Message* reply_message, 1451 IPC::Message* reply_message,
1441 bool wait_for_open) 1452 bool wait_for_open)
1442 : provider_(provider->AsWeakPtr()), 1453 : provider_(provider->AsWeakPtr()),
(...skipping 1714 matching lines...) Expand 10 before | Expand all | Expand 10 after
3157 if (automation_) { 3168 if (automation_) {
3158 AutomationJSONReply(automation_, reply_message_.release()) 3169 AutomationJSONReply(automation_, reply_message_.release())
3159 .SendSuccess(NULL); 3170 .SendSuccess(NULL);
3160 } 3171 }
3161 delete this; 3172 delete this;
3162 } 3173 }
3163 } else { 3174 } else {
3164 NOTREACHED(); 3175 NOTREACHED();
3165 } 3176 }
3166 } 3177 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698