Final set of conversions of automation calls to the JSON interface.

Final set of conversions of automation calls to the JSON interface.

Converts the old bookmark automation commands.

TEST=PyAuto CONTINUOUS suite
BUG=132794
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151380

[craigdh, 2012-08-10 00:40:16]

The last set of automation commands remaining to be moved from
BrowserProxy/TabProxy to the JSON interface.

John: OWNER chrome/browser/automation/*
Nirnimesh: everything

[Nirnimesh, 2012-08-10 04:34:20]

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/browser/automat...
File chrome/browser/automation/automation_provider_observers.h (right):

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/browser/automat...
chrome/browser/automation/automation_provider_observers.h:1049: bool
use_json_interface);
Is this class used by anything other than pyauto?

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/browser/automat...
File chrome/browser/automation/testing_automation_provider.cc (right):

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/browser/automat...
chrome/browser/automation/testing_automation_provider.cc:1400: void
TestingAutomationProvider::WaitForBookmarkModelToLoad(
Is this used anywhere other than pyauto?

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/test/functional...
File chrome/test/functional/bookmarks.py (right):

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/test/functional...
chrome/test/functional/bookmarks.py:22: self.WaitForBookmarkModelToLoad()
how was this working before?

[craigdh, 2012-08-10 18:08:04]

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/browser/automat...
File chrome/browser/automation/automation_provider_observers.h (right):

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/browser/automat...
chrome/browser/automation/automation_provider_observers.h:1049: bool
use_json_interface);
On 2012/08/10 04:34:20, Nirnimesh wrote:
> Is this class used by anything other than pyauto?

Used by WaitForBookmarkModelToLoad, which is used by sync tests. I actually
converted this, then had to switch it back to support both.

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/browser/automat...
File chrome/browser/automation/testing_automation_provider.cc (right):

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/browser/automat...
chrome/browser/automation/testing_automation_provider.cc:1400: void
TestingAutomationProvider::WaitForBookmarkModelToLoad(
On 2012/08/10 04:34:20, Nirnimesh wrote:
> Is this used anywhere other than pyauto?

Yep, looks like it's used by sync tests. I actually removed this then had to add
it back.

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/test/functional...
File chrome/test/functional/bookmarks.py (right):

https://chromiumcodereview.appspot.com/10828245/diff/1/chrome/test/functional...
chrome/test/functional/bookmarks.py:22: self.WaitForBookmarkModelToLoad()
On 2012/08/10 04:34:20, Nirnimesh wrote:
> how was this working before?

I have that same question. Previously the calls just failed silently if the
BookMark model wasn't loaded. Once they raised exceptions the tests didn't pass.

I haven't dug too deeply into it since they pass correctly now.

[Nirnimesh, 2012-08-10 18:14:03]

lgtm

[jam, 2012-08-10 23:39:46]

lgtm

[commit-bot: I haz the power, 2012-08-13 21:03:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/10828245/7001

[commit-bot: I haz the power, 2012-08-13 22:59:05]

Change committed as 151380