Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4149)

Unified Diff: chrome/test/automation/browser_proxy.cc

Issue 10828245: Final set of conversions of automation calls to the JSON interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/automation/browser_proxy.h ('k') | chrome/test/pyautolib/pyauto.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/automation/browser_proxy.cc
diff --git a/chrome/test/automation/browser_proxy.cc b/chrome/test/automation/browser_proxy.cc
index 2d6ac92a37b9f4a5b1ff7711cc93c6fde33cec41..6716da7695190852559f3dc10fa1433e0a3971d0 100644
--- a/chrome/test/automation/browser_proxy.cc
+++ b/chrome/test/automation/browser_proxy.cc
@@ -244,109 +244,6 @@ bool BrowserProxy::RunCommand(int browser_command) const {
return result;
}
-bool BrowserProxy::GetBookmarkBarVisibility(bool* is_visible,
- bool* is_animating,
- bool* is_detached) {
- if (!is_valid())
- return false;
-
- if (!is_visible || !is_animating) {
- NOTREACHED();
- return false;
- }
-
- return sender_->Send(new AutomationMsg_BookmarkBarVisibility(
- handle_, is_visible, is_animating, is_detached));
-}
-
-bool BrowserProxy::GetBookmarksAsJSON(std::string *json_string) {
- if (!is_valid())
- return false;
-
- if (!WaitForBookmarkModelToLoad())
- return false;
-
- bool result = false;
- sender_->Send(new AutomationMsg_GetBookmarksAsJSON(handle_,
- json_string,
- &result));
- return result;
-}
-
-bool BrowserProxy::WaitForBookmarkModelToLoad() {
- if (!is_valid())
- return false;
-
- bool result = false;
- sender_->Send(new AutomationMsg_WaitForBookmarkModelToLoad(handle_, &result));
- return result;
-}
-
-bool BrowserProxy::AddBookmarkGroup(int64 parent_id, int index,
- std::wstring& title) {
- if (!is_valid())
- return false;
- bool result = false;
- sender_->Send(new AutomationMsg_AddBookmarkGroup(handle_,
- parent_id, index,
- title,
- &result));
- return result;
-}
-
-bool BrowserProxy::AddBookmarkURL(int64 parent_id, int index,
- std::wstring& title, const GURL& url) {
- if (!is_valid())
- return false;
- bool result = false;
- sender_->Send(new AutomationMsg_AddBookmarkURL(handle_,
- parent_id, index,
- title, url,
- &result));
- return result;
-}
-
-bool BrowserProxy::ReparentBookmark(int64 id, int64 new_parent_id, int index) {
- if (!is_valid())
- return false;
- bool result = false;
- sender_->Send(new AutomationMsg_ReparentBookmark(handle_,
- id, new_parent_id,
- index,
- &result));
- return result;
-}
-
-bool BrowserProxy::SetBookmarkTitle(int64 id, const std::wstring& title) {
- if (!is_valid())
- return false;
- bool result = false;
- sender_->Send(new AutomationMsg_SetBookmarkTitle(handle_,
- id, title,
- &result));
- return result;
-}
-
-bool BrowserProxy::SetBookmarkURL(int64 id, const GURL& url) {
- if (!is_valid())
- return false;
- bool result = false;
- sender_->Send(new AutomationMsg_SetBookmarkURL(handle_,
- id, url,
- &result));
- return result;
-}
-
-bool BrowserProxy::RemoveBookmark(int64 id) {
- if (!is_valid())
- return false;
- bool result = false;
- sender_->Send(new AutomationMsg_RemoveBookmark(handle_,
- id,
- &result));
- return result;
-}
-
bool BrowserProxy::TerminateSession() {
if (!is_valid())
return false;
« no previous file with comments | « chrome/test/automation/browser_proxy.h ('k') | chrome/test/pyautolib/pyauto.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698