[IME] Stop sending synthesized keyCode, and send 229 instead.

[IME] Stop sending synthesized keyCode, and send 229 instead.

Previously for <input> with autocomplete="off", we send a synthesized keyCode.
This CL disables this feature to send 229 instead (however, backspace still
generates 8).

BUG=476497
Committed: https://crrev.com/b7b72aabc66d2f5d4f77df5d88797304d23dc84d
Cr-Commit-Position: refs/heads/master@{#325524}

[huangs, 2015-04-13 18:02:11]

huangs@chromium.org changed reviewers:
+ aelias@chromium.org, bcwhite@chromium.org

[huangs, 2015-04-13 18:02:11]

PTAL.  Probably want to merge this into branch first.

[aelias_OOO_until_Jul13, 2015-04-13 18:12:29]

On 2015/04/13 at 18:02:11, huangs wrote:
> PTAL.  Probably want to merge this into branch first.

lgtm as a quick fix, but please also wait for bcwhite@'s review before landing.

[bcwhite, 2015-04-13 18:22:37]

lgtm

[kerz_chromium, 2015-04-13 18:28:00]

The CQ bit was checked by kerz@chromium.org

[commit-bot: I haz the power, 2015-04-13 18:28:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1082823002/1

[commit-bot: I haz the power, 2015-04-13 19:09:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-13 19:09:01]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[huangs, 2015-04-13 19:13:59]

huangs@chromium.org changed reviewers:
+ aurimas@chromium.org

[huangs, 2015-04-13 19:14:00]

OWNER review to aurimas@, PTAL.

[huangs, 2015-04-14 18:51:48]

Update: This has been merged into 2311 (M42).  For M43, I'd consider this as the
last resort, and prefer to fix the underlying issue first, rather than disabling
autocomplete="off" and synthesized keyCodes.  Meanwhile, for long term we'd like
to get rid of the autocomlete="off" hack, but need to discuss with aelias@,
bcwhite@, and suzhe@.

[aelias_OOO_until_Jul13, 2015-04-14 19:37:41]

Because M43 has already branched a week ago, I think we should merge the same
fix to it as we did for M42.  We can make deeper improvements for M44.

[huangs, 2015-04-16 21:08:28]

Ping aurimas@: We'll apply this fix to trunk and to M43.  PTAL.

[aurimas (slooooooooow), 2015-04-16 21:10:12]

lgtm

[huangs, 2015-04-16 21:16:28]

Thanks! Committing.

[huangs, 2015-04-16 21:16:48]

The CQ bit was checked by huangs@chromium.org

[huangs, 2015-04-16 21:16:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
bcwhite@chromium.org, aelias@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1082823002/#ps40001
(title: "Fixing test another way.")

[commit-bot: I haz the power, 2015-04-16 21:18:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1082823002/40001

[commit-bot: I haz the power, 2015-04-16 22:12:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-16 22:13:13]

Patchset 3 (id:??) landed as
https://crrev.com/b7b72aabc66d2f5d4f77df5d88797304d23dc84d
Cr-Commit-Position: refs/heads/master@{#325524}

[jdduke (slow), 2015-07-14 16:42:31]

jdduke@chromium.org changed reviewers:
+ jdduke@chromium.org

[jdduke (slow), 2015-07-14 16:42:32]

https://codereview.chromium.org/1082823002/diff/40001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
(right):

https://codereview.chromium.org/1082823002/diff/40001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:438:
modifiers = 0;
Are there any plans to fix this? Are we OK always sending without modifiers
here?

[huangs, 2015-07-14 16:57:45]

https://codereview.chromium.org/1082823002/diff/40001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
(right):

https://codereview.chromium.org/1082823002/diff/40001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:438:
modifiers = 0;
This is the debate between two view points:

A: The concept of modifiers makes no sense for general composition event (e.g.,
consider voice input), so it should be removed for consistency.
B: We should make "best effort" to pass whatever's available in case the
developer has need for it.

The code is following A. While'd I prefer B, this seems to be more pain than
it's worth.

[jdduke (slow), 2015-07-14 17:38:53]

On 2015/07/14 16:57:45, huangs wrote:
>
https://codereview.chromium.org/1082823002/diff/40001/content/public/android/...
> File
>
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
> (right):
> 
>
https://codereview.chromium.org/1082823002/diff/40001/content/public/android/...
>
content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java:438:
> modifiers = 0;
> This is the debate between two view points:
> 
> A: The concept of modifiers makes no sense for general composition event
(e.g.,
> consider voice input), so it should be removed for consistency.
> B: We should make "best effort" to pass whatever's available in case the
> developer has need for it.
> 
> The code is following A. While'd I prefer B, this seems to be more pain than
> it's worth.

I'm OK with either approach, I was more wondering if we wanted to clean up some
of the code that is made unnecessary by this change.

[huangs, 2015-07-14 17:59:55]

Ah, since there are dead branches.  Cleanup would be good but it wasn't done
because I wanted to make minimal change (a rather emergency), and didn't know if
we'll revisit our strategies on emulating key codes.  Please ask bcwhite@ and
see if he's okay with ripping out more stuff.  Thanks!