content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java - Issue 1082823002: [IME] Stop sending synthesized keyCode, and send 229 instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

Issue 1082823002: [IME] Stop sending synthesized keyCode, and send 229 instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing test another way. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('K') | « content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

index 339ce61933d0b87efc40eb14caad076db9d8d603..5752d0a84de09fcb1921ec83600eddb543debd86 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

@@ -733,10 +733,11 @@ public class ImeTest extends ContentShellTestBase {

waitAndVerifyEditableCallback(mConnection.mImeUpdateQueue, 0, "", 0, 0, -1, -1);

// H

- // Since autocomplete="off", regular key codes are emitted.

+ // Although autocomplete="off", we still emit COMPOSITION_KEY_CODE since synthesized

+ // keycodes are disabled.

expectUpdateStateCall(mConnection);

setComposingText(mConnection, "h", 1);

- assertEquals(KeyEvent.KEYCODE_H, mImeAdapter.mLastSyntheticKeyCode);

+ assertEquals(COMPOSITION_KEY_CODE, mImeAdapter.mLastSyntheticKeyCode);

// Simulate switch of input fields.

finishComposingText(mConnection);

@@ -744,7 +745,7 @@ public class ImeTest extends ContentShellTestBase {

// H

expectUpdateStateCall(mConnection);

setComposingText(mConnection, "h", 1);

- assertEquals(KeyEvent.KEYCODE_H, mImeAdapter.mLastSyntheticKeyCode);

+ assertEquals(COMPOSITION_KEY_CODE, mImeAdapter.mLastSyntheticKeyCode);

}

@SmallTest