Make the Mac Info.plist SCM keys generic

Make the Mac Info.plist SCM keys generic

This allows the file_version_info_mac code to make sense for any SCM
(e.g., git). It also aligns the use of FetchVersionInfo to its
documented behavior, which is to return a (branch, revision) tuple
for "some appropriate revision control system".

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153101

[Mark Mentovai, 2012-08-21 13:54:43]

LGTM otherwise

http://codereview.chromium.org/10828228/diff/1/build/mac/tweak_info_plist.py
File build/mac/tweak_info_plist.py (right):

http://codereview.chromium.org/10828228/diff/1/build/mac/tweak_info_plist.py#...
build/mac/tweak_info_plist.py:121: plist['SCMBranch'] = scm_branch
“branch” isn’t really right still though, it’s still a “path” which is more
generic.

[stuartmorgan, 2012-08-22 09:35:54]

http://codereview.chromium.org/10828228/diff/1/build/mac/tweak_info_plist.py
File build/mac/tweak_info_plist.py (right):

http://codereview.chromium.org/10828228/diff/1/build/mac/tweak_info_plist.py#...
build/mac/tweak_info_plist.py:121: plist['SCMBranch'] = scm_branch
On 2012/08/21 13:54:43, Mark Mentovai wrote:
> “branch” isn’t really right still though, it’s still a “path”

Okay, changed to SCMPath, and changed scm_branch back to scm_path. As I said
though, "branch" is the terminology used in lastchange.py for what the function
returns, so there's still a mismatch.

> which is more generic.

I've never heard someone refer to a git branch as a path...

[commit-bot: I haz the power, 2012-08-22 09:36:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10828228/4001

[commit-bot: I haz the power, 2012-08-22 09:36:26]

Presubmit check for 10828228-4001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content
    chrome

[stuartmorgan, 2012-08-22 09:59:04]

+darin for OWNERS

[stuartmorgan, 2012-08-23 09:36:14]

Oops, Darin is out. +jam for OWNERS

[jam, 2012-08-23 17:06:13]

lgtm

[commit-bot: I haz the power, 2012-08-23 19:24:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10828228/4001

[commit-bot: I haz the power, 2012-08-23 22:53:20]

Change committed as 153101