Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2510)

Unified Diff: build/mac/tweak_info_plist.py

Issue 10828228: Make the Mac Info.plist SCM keys generic (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change branch back to path Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_version_info_mac.mm ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/mac/tweak_info_plist.py
diff --git a/build/mac/tweak_info_plist.py b/build/mac/tweak_info_plist.py
index 07a3a0b294ebfd57b976d4bceb8b0a37901088fd..9b57e7da01ba772fc72028250d2403dd5d4c9744 100755
--- a/build/mac/tweak_info_plist.py
+++ b/build/mac/tweak_info_plist.py
@@ -101,8 +101,8 @@ def _AddVersionKeys(plist):
return True
-def _DoSVNKeys(plist, add_keys):
- """Adds the SVN information, visible in about:version, to property list. If
+def _DoSCMKeys(plist, add_keys):
+ """Adds the SCM information, visible in about:version, to property list. If
|add_keys| is True, it will insert the keys, otherwise it will remove them."""
scm_path, scm_revision = None, None
if add_keys:
@@ -111,16 +111,16 @@ def _DoSVNKeys(plist, add_keys):
scm_path, scm_revision = version_info.url, version_info.revision
# See if the operation failed.
- _RemoveKeys(plist, 'SVNRevision')
+ _RemoveKeys(plist, 'SCMRevision')
if scm_revision != None:
- plist['SVNRevision'] = scm_revision
+ plist['SCMRevision'] = scm_revision
elif add_keys:
- print >>sys.stderr, 'Could not determine svn revision. This may be OK.'
+ print >>sys.stderr, 'Could not determine SCM revision. This may be OK.'
if scm_path != None:
- plist['SVNPath'] = scm_path
+ plist['SCMPath'] = scm_path
else:
- _RemoveKeys(plist, 'SVNPath')
+ _RemoveKeys(plist, 'SCMPath')
def _DoPDFKeys(plist, add_keys):
@@ -220,8 +220,8 @@ def Main(argv):
help='Enable Breakpad\'s uploading of crash dumps [1 or 0]')
parser.add_option('--keystone', dest='use_keystone', action='store',
type='int', default=False, help='Enable Keystone [1 or 0]')
- parser.add_option('--svn', dest='add_svn_info', action='store', type='int',
- default=True, help='Add SVN metadata [1 or 0]')
+ parser.add_option('--scm', dest='add_scm_info', action='store', type='int',
+ default=True, help='Add SCM metadata [1 or 0]')
parser.add_option('--pdf', dest='add_pdf_support', action='store', type='int',
default=False, help='Add PDF file handler support [1 or 0]')
parser.add_option('--branding', dest='branding', action='store',
@@ -271,8 +271,8 @@ def Main(argv):
else:
_RemoveKeystoneKeys(plist)
- # Adds or removes any SVN keys.
- _DoSVNKeys(plist, options.add_svn_info)
+ # Adds or removes any SCM keys.
+ _DoSCMKeys(plist, options.add_scm_info)
# Adds or removes the PDF file handler entry.
_DoPDFKeys(plist, options.add_pdf_support)
« no previous file with comments | « base/file_version_info_mac.mm ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698