Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: third_party/libxml/libxml.gyp

Issue 10828214: Add a comment explaining why we need libxml's multithreading mode (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: comment Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libxml/libxml.gyp
diff --git a/third_party/libxml/libxml.gyp b/third_party/libxml/libxml.gyp
index 79a1bc23a79f1c2d4efe7e6b54b9d8d266551b9a..a180ee6e671d0b18b81e796d42d5e0b32a79a220 100644
--- a/third_party/libxml/libxml.gyp
+++ b/third_party/libxml/libxml.gyp
@@ -218,6 +218,10 @@
],
},
}],
+ # http://www.xmlsoft.org/threads.html says that this is required
+ # when using libxml from several threads, which can possibly happen
+ # in chrome. On linux, this is picked up by transitivity from
+ # pkg-config output from build/linux/system.gyp.
['OS=="mac" or OS=="android"', {'defines': ['_REENTRANT']}],
['OS=="win"', {
'product_name': 'libxml2',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698