Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: third_party/libxml/libxml.gyp

Issue 10828214: Add a comment explaining why we need libxml's multithreading mode (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: comment Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'conditions': [ 7 'conditions': [
8 # Define an "os_include" variable that points at the OS-specific generated 8 # Define an "os_include" variable that points at the OS-specific generated
9 # headers. These were generated by running the configure script offline. 9 # headers. These were generated by running the configure script offline.
10 ['os_posix == 1 and OS != "mac" and OS != "ios"', { 10 ['os_posix == 1 and OS != "mac" and OS != "ios"', {
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 }, 211 },
212 'conditions': [ 212 'conditions': [
213 ['OS=="linux"', { 213 ['OS=="linux"', {
214 'link_settings': { 214 'link_settings': {
215 'libraries': [ 215 'libraries': [
216 # We need dl for dlopen() and friends. 216 # We need dl for dlopen() and friends.
217 '-ldl', 217 '-ldl',
218 ], 218 ],
219 }, 219 },
220 }], 220 }],
221 # http://www.xmlsoft.org/threads.html says that this is required
222 # when using libxml from several threads, which can possibly happen
223 # in chrome. On linux, this is picked up by transitivity from
224 # pkg-config output from build/linux/system.gyp.
221 ['OS=="mac" or OS=="android"', {'defines': ['_REENTRANT']}], 225 ['OS=="mac" or OS=="android"', {'defines': ['_REENTRANT']}],
222 ['OS=="win"', { 226 ['OS=="win"', {
223 'product_name': 'libxml2', 227 'product_name': 'libxml2',
224 # Disable unimportant 'unused variable' warning, and 228 # Disable unimportant 'unused variable' warning, and
225 # signed/unsigned comparison warning. The signed/unsigned (4101) 229 # signed/unsigned comparison warning. The signed/unsigned (4101)
226 # is fixed upstream and can be removed eventually. 230 # is fixed upstream and can be removed eventually.
227 'msvs_disabled_warnings': [ 4018, 4101 ], 231 'msvs_disabled_warnings': [ 4018, 4101 ],
228 }, { # else: OS!="win" 232 }, { # else: OS!="win"
229 'product_name': 'xml2', 233 'product_name': 'xml2',
230 }], 234 }],
(...skipping 13 matching lines...) Expand all
244 '-Wno-pointer-sign', 248 '-Wno-pointer-sign',
245 '-Wno-empty-body', 249 '-Wno-empty-body',
246 ], 250 ],
247 }], 251 }],
248 ], 252 ],
249 }], 253 }],
250 ], 254 ],
251 }, 255 },
252 ], 256 ],
253 } 257 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698