Issue 10828124: Always use non-low-latency (wave out) audio for Pepper plugins on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828124: Always use non-low-latency (wave out) audio for Pepper plugins on Windows. (Closed)

Created:
8 years, 4 months ago by viettrungluu

Modified:
8 years, 4 months ago

Reviewers:
cpu_(ooo_6.6-7.5), brettw, scherkus (not reviewing)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Always use non-low-latency (wave out) audio for Pepper plugins on Windows. (In particular, for Pepper Flash.) The intent is to try this out on Canary for M21, merge it to M21 if it looks good, and then revert this change. BUG=139953 TBR=cpu,brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149508

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	content/renderer/pepper/pepper_platform_audio_output_impl.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

cpu already reviewed the 1180 (M21) version @ http://codereview.chromium.org/10824135/ . TBRing him here, and brettw ...

8 years, 4 months ago (2012-08-01 22:06:29 UTC) #2

LGTM

Expand Messages | Collapse Messages