Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1685)

Unified Diff: crypto/ec_signature_creator.cc

Issue 10828118: Add a DCHECK to ECSignatureCreator::SetFactoryForTesting to help avoid use-after-free problems. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crypto/ec_signature_creator.cc
diff --git a/crypto/ec_signature_creator.cc b/crypto/ec_signature_creator.cc
index cbaa820cec96001eb4ad79c3f33312db043920ec..a6887bc117b7f5e7206e42d62367a9c3be571ad3 100644
--- a/crypto/ec_signature_creator.cc
+++ b/crypto/ec_signature_creator.cc
@@ -4,6 +4,7 @@
#include "crypto/ec_signature_creator.h"
+#include "base/logging.h"
#include "crypto/ec_signature_creator_impl.h"
namespace crypto {
@@ -24,6 +25,9 @@ ECSignatureCreator* ECSignatureCreator::Create(ECPrivateKey* key) {
// static
void ECSignatureCreator::SetFactoryForTesting(
ECSignatureCreatorFactory* factory) {
+ // We should always clear the factory after each test to avoid
+ // use-after-free problems.
+ DCHECK(!g_factory_ || !factory);
g_factory_ = factory;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698