Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Side by Side Diff: crypto/ec_signature_creator.cc

Issue 10828118: Add a DCHECK to ECSignatureCreator::SetFactoryForTesting to help avoid use-after-free problems. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "crypto/ec_signature_creator.h" 5 #include "crypto/ec_signature_creator.h"
6 6
7 #include "base/logging.h"
7 #include "crypto/ec_signature_creator_impl.h" 8 #include "crypto/ec_signature_creator_impl.h"
8 9
9 namespace crypto { 10 namespace crypto {
10 11
11 namespace { 12 namespace {
12 13
13 ECSignatureCreatorFactory* g_factory_ = NULL; 14 ECSignatureCreatorFactory* g_factory_ = NULL;
14 15
15 } // namespace 16 } // namespace
16 17
17 // static 18 // static
18 ECSignatureCreator* ECSignatureCreator::Create(ECPrivateKey* key) { 19 ECSignatureCreator* ECSignatureCreator::Create(ECPrivateKey* key) {
19 if (g_factory_) 20 if (g_factory_)
20 return g_factory_->Create(key); 21 return g_factory_->Create(key);
21 return new ECSignatureCreatorImpl(key); 22 return new ECSignatureCreatorImpl(key);
22 } 23 }
23 24
24 // static 25 // static
25 void ECSignatureCreator::SetFactoryForTesting( 26 void ECSignatureCreator::SetFactoryForTesting(
26 ECSignatureCreatorFactory* factory) { 27 ECSignatureCreatorFactory* factory) {
28 // We should always clear the factory after each test to avoid
29 // use-after-free problems.
30 DCHECK(!g_factory_ || !factory);
27 g_factory_ = factory; 31 g_factory_ = factory;
28 } 32 }
29 33
30 } // namespace crypto 34 } // namespace crypto
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698