Issue 10828061: Remove target chromium_swarm_tests when test_isolate_mode == noop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10828061: Remove target chromium_swarm_tests when test_isolate_mode == noop. (Closed)

Created:
8 years, 4 months ago by M-A Ruel

Modified:
8 years, 4 months ago

Reviewers:
cmp

CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Dirk Pranke, csharp

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove target chromium_swarm_tests when test_isolate_mode == noop. This is the default value. It can be overridden with GYP_DEFINES. It is with the swarm master. Also remove the corresponding XXX_run targets. These can be problematic when developers are moving files around, especially with DEPS rolls. This simplifies build slave management during the deployment as the .isolate files are being rolled out. TBR=cmp@chromium.org NOTRY=true BUG=139426 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148854

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -154 lines)			Patch
M	base/base.gyp	View	1	2 chunks	+36 lines, -32 lines	0 comments	Download
M	build/all.gyp	View	1	2 chunks	+14 lines, -21 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	3 chunks	+66 lines, -62 lines	0 comments	Download
M	net/net.gyp	View	1 2	2 chunks	+36 lines, -39 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10828061/3001

8 years, 4 months ago (2012-07-28 00:03:34 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 10828061: Remove target chromium_swarm_tests when test_isolate_mode == noop. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages