Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: chrome/chrome_tests.gypi

Issue 10828061: Remove target chromium_swarm_tests when test_isolate_mode == noop. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | net/net.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index f4ab4bab8f34c09e539ad1eb4ef4fbb651849380..85df0a5cfa309fe6b6c8b17b8fe0e505a3df10e1 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -2564,37 +2564,6 @@
],
},
{
- 'target_name': 'unit_tests_run',
- 'type': 'none',
- 'dependencies': [
- 'unit_tests',
- ],
- 'includes': [
- 'unit_tests.isolate',
- ],
- 'actions': [
- {
- 'action_name': 'isolate',
- 'inputs': [
- '<@(isolate_dependency_tracked)',
- ],
- 'outputs': [
- '<(PRODUCT_DIR)/unit_tests.results',
- ],
- 'action': [
- 'python',
- '../tools/isolate/isolate.py',
- '<(test_isolation_mode)',
- '--outdir', '<(test_isolation_outdir)',
- '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)',
- '--variable', 'OS', '<(OS)',
- '--result', '<@(_outputs)',
- '--isolate', 'unit_tests.isolate',
- ],
- },
- ],
- },
- {
# Executable that runs each browser test in a new process.
'target_name': 'browser_tests',
'type': 'executable',
@@ -3315,37 +3284,6 @@
], # conditions
}, # target browser_tests
{
- 'target_name': 'browser_tests_run',
- 'type': 'none',
- 'dependencies': [
- 'browser_tests',
- ],
- 'includes': [
- 'browser_tests.isolate',
- ],
- 'actions': [
- {
- 'action_name': 'isolate',
- 'inputs': [
- '<@(isolate_dependency_tracked)',
- ],
- 'outputs': [
- '<(PRODUCT_DIR)/browser_tests.results',
- ],
- 'action': [
- 'python',
- '../tools/isolate/isolate.py',
- '<(test_isolation_mode)',
- '--outdir', '<(test_isolation_outdir)',
- '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)',
- '--variable', 'OS', '<(OS)',
- '--result', '<@(_outputs)',
- '--isolate', 'browser_tests.isolate',
- ],
- },
- ],
- },
- {
# Executable that runs each perf browser test in a new process.
'target_name': 'performance_browser_tests',
'type': 'executable',
@@ -4631,5 +4569,71 @@
},
],
}],
+ ['test_isolation_mode != "noop"', {
+ 'targets': [
+ {
+ 'target_name': 'unit_tests_run',
+ 'type': 'none',
+ 'dependencies': [
+ 'unit_tests',
+ ],
+ 'includes': [
+ 'unit_tests.isolate',
+ ],
+ 'actions': [
+ {
+ 'action_name': 'isolate',
+ 'inputs': [
+ '<@(isolate_dependency_tracked)',
+ ],
+ 'outputs': [
+ '<(PRODUCT_DIR)/unit_tests.results',
+ ],
+ 'action': [
+ 'python',
+ '../tools/isolate/isolate.py',
+ '<(test_isolation_mode)',
+ '--outdir', '<(test_isolation_outdir)',
+ '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)',
+ '--variable', 'OS', '<(OS)',
+ '--result', '<@(_outputs)',
+ '--isolate', 'unit_tests.isolate',
+ ],
+ },
+ ],
+ },
+ {
+ 'target_name': 'browser_tests_run',
+ 'type': 'none',
+ 'dependencies': [
+ 'browser_tests',
+ ],
+ 'includes': [
+ 'browser_tests.isolate',
+ ],
+ 'actions': [
+ {
+ 'action_name': 'isolate',
+ 'inputs': [
+ '<@(isolate_dependency_tracked)',
+ ],
+ 'outputs': [
+ '<(PRODUCT_DIR)/browser_tests.results',
+ ],
+ 'action': [
+ 'python',
+ '../tools/isolate/isolate.py',
+ '<(test_isolation_mode)',
+ '--outdir', '<(test_isolation_outdir)',
+ '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)',
+ '--variable', 'OS', '<(OS)',
+ '--result', '<@(_outputs)',
+ '--isolate', 'browser_tests.isolate',
+ ],
+ },
+ ],
+ },
+ ],
+ }],
], # 'conditions'
}
« no previous file with comments | « build/all.gyp ('k') | net/net.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698