Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 10828021: Simplify ParseCWSChannelServiceResponse (Closed)

Created:
8 years, 5 months ago by Tyler Breisacher (Chromium)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Simplify ParseCWSChannelServiceResponse CID=104393 BUG= TEST= TBR=mihaip@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M chrome/browser/extensions/app_notify_channel_setup.cc View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Tyler Breisacher (Chromium)
Coverity was complaining that we didn't check the return value of GetAsString, this seems like ...
8 years, 5 months ago (2012-07-25 21:24:58 UTC) #1
Munjal (Google)
LGTM
8 years, 5 months ago (2012-07-25 23:06:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10828021/1
8 years, 5 months ago (2012-07-25 23:09:01 UTC) #3
commit-bot: I haz the power
Presubmit check for 10828021-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-25 23:09:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10828021/1
8 years, 5 months ago (2012-07-25 23:11:54 UTC) #5
Mihai Parparita -not on Chrome
LGTM
8 years, 5 months ago (2012-07-25 23:41:36 UTC) #6
commit-bot: I haz the power
Try job failure for 10828021-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-25 23:45:11 UTC) #7
Tyler Breisacher (Chromium)
Looks unrelated, trying again.
8 years, 5 months ago (2012-07-25 23:55:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/10828021/1
8 years, 5 months ago (2012-07-25 23:55:41 UTC) #9
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 02:13:29 UTC) #10
Change committed as 148475

Powered by Google App Engine
This is Rietveld 408576698